Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2850053002: Check DirectCompositionOverlays field trial only if hardware supports it (Closed)

Created:
3 years, 7 months ago by jbauman
Modified:
3 years, 7 months ago
Reviewers:
sunnyps
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check DirectCompositionOverlays field trial only if hardware supports it On most systems the hardware doesn't actually support it, which means that gathered statistics for the enabled group also include a lot of machines that don't use overlays, which makes analysis difficult. This change causes the overlay detection code to always run (on Win10 with DirectComposition enabled), but it seems fast and stable enough for that not to be an issue. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2850053002 Cr-Commit-Position: refs/heads/master@{#468753} Committed: https://chromium.googlesource.com/chromium/src/+/11424aa959bd5bf9b97bc7aec1e7a0c6db5527c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -45 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 2 chunks +50 lines, -45 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jbauman
3 years, 7 months ago (2017-05-01 21:14:52 UTC) #7
sunnyps
lgtm
3 years, 7 months ago (2017-05-02 19:03:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850053002/1
3 years, 7 months ago (2017-05-02 19:12:01 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 20:06:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11424aa959bd5bf9b97bc7aec1e7...

Powered by Google App Engine
This is Rietveld 408576698