Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2850023002: dart2js: rewrite_async: Don't call JavaScript factory constructor with 'new' (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: rewrite_async: Don't call JavaScript factory constructor with 'new' 'new' does an unused allocation in this case, since the factory is a static method. R=efortuna@google.com Also: use literal syntax for lists. Committed: https://github.com/dart-lang/sdk/commit/7f3b385d4ce6c09861791cdd02bad904c9f2164a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 17 chunks +26 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sra1
3 years, 7 months ago (2017-04-29 17:02:56 UTC) #3
sra1
3 years, 7 months ago (2017-05-01 19:47:54 UTC) #5
Emily Fortuna
lgtm
3 years, 7 months ago (2017-05-01 22:48:54 UTC) #7
sra1
Committed patchset #1 (id:1) manually as 7f3b385d4ce6c09861791cdd02bad904c9f2164a (presubmit successful).
3 years, 7 months ago (2017-05-01 23:51:15 UTC) #9
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-02 19:22:05 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698