Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2850023002: dart2js: rewrite_async: Don't call JavaScript factory constructor with 'new' (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js/rewrite_async.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index af753d187d68c7bec872cd1c8b4bb96b63a4cb50..598763a62eb216e4565bcf181a98c8af5a69effc 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -1288,7 +1288,7 @@ class JavaScriptBackend {
asyncHelper:
emitter.staticFunctionAccess(commonElements.asyncHelper),
wrapBody: emitter.staticFunctionAccess(commonElements.wrapBody),
- newCompleter: emitter
+ completerFactory: emitter
.staticFunctionAccess(commonElements.syncCompleterConstructor),
safeVariableName: namer.safeVariablePrefixForAsyncRewrite,
bodyName: namer.deriveAsyncBodyName(name));
@@ -1297,7 +1297,7 @@ class JavaScriptBackend {
rewriter = new SyncStarRewriter(reporter, element,
endOfIteration:
emitter.staticFunctionAccess(commonElements.endOfIteration),
- newIterable: emitter.staticFunctionAccess(
+ iterableFactory: emitter.staticFunctionAccess(
commonElements.syncStarIterableConstructor),
yieldStarExpression:
emitter.staticFunctionAccess(commonElements.yieldStar),
« no previous file with comments | « pkg/compiler/lib/src/js/rewrite_async.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698