Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2849993002: [Home] Fix toolbar color when switching tab models (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix toolbar color when switching tab models When the tab model switches, the bottom sheet content changes to suit the normal or incognito tab. This can happen in the tab switcher while the toolbar is transparent causing the toolbar to flash grey. This change skips the transition animation if in tab switcher mode. BUG=702717 Review-Url: https://codereview.chromium.org/2849993002 Cr-Commit-Position: refs/heads/master@{#468194} Committed: https://chromium.googlesource.com/chromium/src/+/38ce97ec22ab1faecb1523f2d00eef0e17568043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mdjones
ptal
3 years, 7 months ago (2017-04-28 22:48:19 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-04-28 23:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849993002/1
3 years, 7 months ago (2017-04-28 23:30:43 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 00:42:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38ce97ec22ab1faecb1523f2d00e...

Powered by Google App Engine
This is Rietveld 408576698