Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2849973003: DevTools: remove continue to location from behind experiment. (Closed)

Created:
3 years, 7 months ago by pfeldman
Modified:
3 years, 7 months ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove continue to location from behind experiment. BUG= Review-Url: https://codereview.chromium.org/2849973003 Cr-Commit-Position: refs/heads/master@{#468386} Committed: https://chromium.googlesource.com/chromium/src/+/191c1eb6c8138e7ab76415c8b149f1879b44963b

Patch Set 1 #

Patch Set 2 : same #

Total comments: 2

Patch Set 3 : same? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -19 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 1 chunk +25 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 2 10 chunks +49 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
pfeldman
3 years, 7 months ago (2017-04-29 00:11:05 UTC) #2
dgozman
https://codereview.chromium.org/2849973003/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js File third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/2849973003/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode490 third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:490: this._clearContinueToLocations(); So this rebuilds inline values on every key ...
3 years, 7 months ago (2017-04-29 00:36:56 UTC) #5
pfeldman
PTAL
3 years, 7 months ago (2017-05-01 17:22:28 UTC) #6
dgozman
lgtm
3 years, 7 months ago (2017-05-01 18:34:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849973003/40001
3 years, 7 months ago (2017-05-01 19:25:54 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 19:32:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/191c1eb6c8138e7ab76415c8b149...

Powered by Google App Engine
This is Rietveld 408576698