Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2849943002: android: Remove sBindingManagerLock (Closed)

Created:
3 years, 7 months ago by boliu
Modified:
3 years, 7 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove sBindingManagerLock Everything calling getBindingManager is already on launcher thread. This removes the last lock in android's ChildProcessLauncher. BUG=689758 Review-Url: https://codereview.chromium.org/2849943002 Cr-Commit-Position: refs/heads/master@{#468173} Committed: https://chromium.googlesource.com/chromium/src/+/43d9f387a0febd1c7b5ea74b121a6e485638cbdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
boliu
last one!
3 years, 7 months ago (2017-04-28 19:08:16 UTC) #2
Jay Civelli
lgtm
3 years, 7 months ago (2017-04-28 20:11:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849943002/1
3 years, 7 months ago (2017-04-28 23:06:16 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 23:11:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43d9f387a0febd1c7b5ea74b121a...

Powered by Google App Engine
This is Rietveld 408576698