Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2849913002: Fix a compile error (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a compile error std::less requires #include <functional>, see e.g. http://en.cppreference.com/w/cpp/utility/functional/less See the bug for more context. BUG=716504 Review-Url: https://codereview.chromium.org/2849913002 Cr-Commit-Position: refs/heads/master@{#468088} Committed: https://chromium.googlesource.com/chromium/src/+/c47196bd73aa1a84ef4603c510dcd2175703cb75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/containers/flat_set.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-04-28 16:53:25 UTC) #2
danakj
LGTM
3 years, 7 months ago (2017-04-28 17:18:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849913002/1
3 years, 7 months ago (2017-04-28 17:29:17 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 19:20:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c47196bd73aa1a84ef4603c510dc...

Powered by Google App Engine
This is Rietveld 408576698