Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2849903003: Fix suborigin dom storage test to wrap all asserts in test steps. (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
jsbell
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix suborigin dom storage test to wrap all asserts in test steps. BUG=None Review-Url: https://codereview.chromium.org/2849903003 Cr-Commit-Position: refs/heads/master@{#468100} Committed: https://chromium.googlesource.com/chromium/src/+/9eb381166018fa2be0d54a787dfcef8ab396e6e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-storage-dom-access.php View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Marijn Kruisselbrink
3 years, 7 months ago (2017-04-28 19:12:58 UTC) #4
jsbell
lgtm
3 years, 7 months ago (2017-04-28 19:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849903003/1
3 years, 7 months ago (2017-04-28 19:35:10 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 19:52:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9eb381166018fa2be0d54a787dfc...

Powered by Google App Engine
This is Rietveld 408576698