Shorten USB enumeration control transfer timeouts to 2 seconds

Shorten USB enumeration control transfer timeouts to 2 seconds

One minute was a completely ridiculous timeout length as this means that
Chrome will behave as if the device simply doesn't exist until the bad
transfer times out. If the device isn't responding in a couple seconds
it likely never will.

BUG=None

Review-Url: https://codereview.chromium.org/2849893003
Cr-Commit-Position: refs/heads/master@{#468221}
Committed: https://chromium.googlesource.com/chromium/src/+/f8e111a1107118e760f1883c8327d0c1ccd0f26a

[Reilly Grant (use Gerrit), 2017-04-29 01:24:43]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 01:25:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-04-29 01:26:39]

reillyg@chromium.org changed reviewers:
+ mcasas@chromium.org

[Reilly Grant (use Gerrit), 2017-04-29 01:26:39]

PTAL

[mcasas, 2017-04-29 01:33:16]

lgtm

https://codereview.chromium.org/2849893003/diff/1/device/usb/usb_descriptors.cc
File device/usb/usb_descriptors.cc (right):

https://codereview.chromium.org/2849893003/diff/1/device/usb/usb_descriptors....
device/usb/usb_descriptors.cc:44: const int kControlTransferTimeout = 2000;  //
2 seconds
nit: consider encoding the units in the name, e.g.
kControlTransferTimeoutMs

[Reilly Grant (use Gerrit), 2017-04-29 01:34:52]

Add units to the constant name

[Reilly Grant (use Gerrit), 2017-04-29 01:35:09]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-04-29 01:35:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2849893003/#ps20001
(title: "Add units to the constant name")

[commit-bot: I haz the power, 2017-04-29 01:35:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 03:20:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493429709960510,
"parent_rev": "dbe2663c06b2836e528013a90269cf8bf9511820", "commit_rev":
"f8e111a1107118e760f1883c8327d0c1ccd0f26a"}

[commit-bot: I haz the power, 2017-04-29 03:21:04]

Description was changed from

==========
Shorten USB enumeration control transfer timeouts to 2 seconds

One minute was a completely ridiculous timeout length as this means that
Chrome will behave as if the device simply doesn't exist until the bad
transfer times out. If the device isn't responding in a couple seconds
it likely never will.

BUG=None
==========

to

==========
Shorten USB enumeration control transfer timeouts to 2 seconds

One minute was a completely ridiculous timeout length as this means that
Chrome will behave as if the device simply doesn't exist until the bad
transfer times out. If the device isn't responding in a couple seconds
it likely never will.

BUG=None

Review-Url: https://codereview.chromium.org/2849893003
Cr-Commit-Position: refs/heads/master@{#468221}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8e111a1107118e760f1883c8327...
==========

[commit-bot: I haz the power, 2017-04-29 03:21:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8e111a1107118e760f1883c8327...