Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2849823005: Inline two methods of QuicChromiumClientSession (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline two methods of QuicChromiumClientSession which are only called from one place: RecordAndCloseSessionOnError CloseSessionOnErrorInner Review-Url: https://codereview.chromium.org/2849823005 Cr-Commit-Position: refs/heads/master@{#468272} Committed: https://chromium.googlesource.com/chromium/src/+/90f64ebe085b18db5d6ddac9aa231d1b76c2752b

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -28 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 2 chunks +2 lines, -14 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ryan Hamilton
3 years, 7 months ago (2017-04-29 20:56:03 UTC) #2
Zhongyi Shi
lgtm https://codereview.chromium.org/2849823005/diff/1/net/quic/chromium/quic_chromium_client_session.h File net/quic/chromium/quic_chromium_client_session.h (right): https://codereview.chromium.org/2849823005/diff/1/net/quic/chromium/quic_chromium_client_session.h#newcode225 net/quic/chromium/quic_chromium_client_session.h:225: // Close the session because of |error| and ...
3 years, 7 months ago (2017-04-29 21:05:19 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/2849823005/diff/1/net/quic/chromium/quic_chromium_client_session.h File net/quic/chromium/quic_chromium_client_session.h (right): https://codereview.chromium.org/2849823005/diff/1/net/quic/chromium/quic_chromium_client_session.h#newcode225 net/quic/chromium/quic_chromium_client_session.h:225: // Close the session because of |error| and ...
3 years, 7 months ago (2017-05-01 02:02:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849823005/20001
3 years, 7 months ago (2017-05-01 02:02:22 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 03:08:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90f64ebe085b18db5d6ddac9aa23...

Powered by Google App Engine
This is Rietveld 408576698