Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2849763004: [heap] Remove unused field of IterateAndScavengePromotedObjectsVisitor. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unused field of IterateAndScavengePromotedObjectsVisitor. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2849763004 Cr-Commit-Position: refs/heads/master@{#44977} Committed: https://chromium.googlesource.com/v8/v8/+/1c54214456b64aaed014b60a887d6010dfe99a78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/heap/heap.cc View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ulan
ptal
3 years, 7 months ago (2017-04-28 11:50:43 UTC) #2
Michael Lippautz (Google)
lgtm
3 years, 7 months ago (2017-04-28 11:53:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849763004/1
3 years, 7 months ago (2017-04-28 11:53:48 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-04-28 11:53:49 UTC) #8
Michael Lippautz
lgtm
3 years, 7 months ago (2017-04-28 12:09:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849763004/1
3 years, 7 months ago (2017-04-28 12:26:27 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 12:57:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1c54214456b64aaed014b60a887d6010dfe...

Powered by Google App Engine
This is Rietveld 408576698