Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2849763003: ntp_snippets: fix ./fetch.py --short (Closed)

Created:
3 years, 7 months ago by sfiera
Modified:
3 years, 7 months ago
Reviewers:
Marc Treib, fhorschig
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ntp_snippets: fix ./fetch.py --short When I broke out a function, I mixed up the request and the JSON for the argument. Review-Url: https://codereview.chromium.org/2849763003 Cr-Commit-Position: refs/heads/master@{#467982} Committed: https://chromium.googlesource.com/chromium/src/+/1824ef1f2ac1b1e233bbe1934d8d2060aa9f42a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/ntp_snippets/remote/fetch.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sfiera
3 years, 7 months ago (2017-04-28 12:13:17 UTC) #2
fhorschig
lgtm
3 years, 7 months ago (2017-04-28 12:24:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849763003/1
3 years, 7 months ago (2017-04-28 12:29:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/423147)
3 years, 7 months ago (2017-04-28 12:37:20 UTC) #7
sfiera
Oops. I forgot that fhorschig doesn't exist.
3 years, 7 months ago (2017-04-28 12:40:34 UTC) #9
Marc Treib
On 2017/04/28 12:40:34, sfiera wrote: > Oops. I forgot that fhorschig doesn't exist. As in, ...
3 years, 7 months ago (2017-04-28 12:42:28 UTC) #10
vitaliii
On 2017/04/28 12:42:28, Marc Treib wrote: > On 2017/04/28 12:40:34, sfiera wrote: > > Oops. ...
3 years, 7 months ago (2017-04-28 12:43:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849763003/1
3 years, 7 months ago (2017-04-28 12:45:58 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 13:36:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1824ef1f2ac1b1e233bbe1934d8d...

Powered by Google App Engine
This is Rietveld 408576698