Remove non-existing headers from the build

Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

8 missing headers in the build were fixed because they were moved.

BUG=716359
Review-Url: https://codereview.chromium.org/2849763002
Cr-Commit-Position: refs/heads/master@{#468237}
Committed: https://chromium.googlesource.com/chromium/src/+/31719eefcc4e06a6cb0b41364eb91d0857c2ce2f

[wychen, 2017-04-28 07:54:44]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 07:54:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-04-28 08:04:19]

Description was changed from

==========
Remove extra headers from GN

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=661774
==========

to

==========
Remove extra headers from GN

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=716359
==========

[wychen, 2017-04-28 08:09:27]

wychen@chromium.org changed reviewers:
+ thakis@chromium.org

[wychen, 2017-04-28 08:35:13]

PTAL

[commit-bot: I haz the power, 2017-04-28 08:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 08:58:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wychen, 2017-04-28 17:52:46]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 17:53:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lambros, 2017-04-28 17:53:43]

lambroslambrou@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2017-04-28 17:53:44]

remoting lgtm

[wychen, 2017-04-28 18:13:22]

Description was changed from

==========
Remove extra headers from GN

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=716359
==========

to

==========
Remove non-existing headers from GN

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=716359
==========

[Nico, 2017-04-28 18:15:33]

https://codereview.chromium.org/2849763002/diff/1/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (left):

https://codereview.chromium.org/2849763002/diff/1/base/allocator/BUILD.gn#old...
base/allocator/BUILD.gn:175: "$tcmalloc_dir/src/malloc_hook.h",
That's probably this one:
https://cs.chromium.org/chromium/src/third_party/tcmalloc/chromium/src/gperft...

(probably true for other files in this BUILD file)

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
File third_party/WebKit/public/BUILD.gn (left):

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:434: "platform/modules/vr/WebVR.h",
can also be removed here:
https://cs.chromium.org/chromium/src/content/browser/DEPS?type=cs&q=webvr.h&l...

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:441: "platform/scheduler/base/task_queue.h",
please check all the platform/scheduler files -- I checked the last two and they
both exist, but elsewhere

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:448:
"platform/scheduler/child/worker_scheduler.h",
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/sched...

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:454:
"platform/scheduler/utility/webthread_impl_for_utility_thread.h",
This is probably
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/sched...
which isn't mentioned in any BUILD files -- probably should be mentioned in the
non-public one

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:587: "web/WebSourceLocation.h",
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebSo...

https://codereview.chromium.org/2849763002/diff/1/ui/latency/BUILD.gn
File ui/latency/BUILD.gn (left):

https://codereview.chromium.org/2849763002/diff/1/ui/latency/BUILD.gn#oldcode9
ui/latency/BUILD.gn:9: "latency/latency_histogram_macros.h",
https://cs.chromium.org/chromium/src/ui/latency/latency_histogram_macros.h?q=...
(i.e. remove "latency/")

[commit-bot: I haz the power, 2017-04-28 19:01:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:01:43]

Dry run: This issue passed the CQ dry run.

[wychen, 2017-04-28 19:02:04]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 19:04:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-04-28 19:19:06]

https://codereview.chromium.org/2849763002/diff/1/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (left):

https://codereview.chromium.org/2849763002/diff/1/base/allocator/BUILD.gn#old...
base/allocator/BUILD.gn:175: "$tcmalloc_dir/src/malloc_hook.h",
On 2017/04/28 18:15:33, Nico wrote:
> That's probably this one:
>
https://cs.chromium.org/chromium/src/third_party/tcmalloc/chromium/src/gperft...
> 
> (probably true for other files in this BUILD file)

Done.

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
File third_party/WebKit/public/BUILD.gn (left):

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:434: "platform/modules/vr/WebVR.h",
On 2017/04/28 18:15:33, Nico wrote:
> can also be removed here:
>
https://cs.chromium.org/chromium/src/content/browser/DEPS?type=cs&q=webvr.h&l...

Done.

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:441: "platform/scheduler/base/task_queue.h",
On 2017/04/28 18:15:33, Nico wrote:
> please check all the platform/scheduler files -- I checked the last two and
they
> both exist, but elsewhere

Done.

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:448:
"platform/scheduler/child/worker_scheduler.h",
On 2017/04/28 18:15:33, Nico wrote:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/sched...

Done.

https://codereview.chromium.org/2849763002/diff/1/third_party/WebKit/public/B...
third_party/WebKit/public/BUILD.gn:454:
"platform/scheduler/utility/webthread_impl_for_utility_thread.h",
On 2017/04/28 18:15:33, Nico wrote:
> This is probably
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/sched...
> which isn't mentioned in any BUILD files -- probably should be mentioned in
the
> non-public one

Done.

https://codereview.chromium.org/2849763002/diff/1/ui/latency/BUILD.gn
File ui/latency/BUILD.gn (left):

https://codereview.chromium.org/2849763002/diff/1/ui/latency/BUILD.gn#oldcode9
ui/latency/BUILD.gn:9: "latency/latency_histogram_macros.h",
On 2017/04/28 18:15:33, Nico wrote:
>
https://cs.chromium.org/chromium/src/ui/latency/latency_histogram_macros.h?q=...
> (i.e. remove "latency/")

Nice! Fix missing header at the same time! Done.

[Nico, 2017-04-28 19:56:42]

lgtm

[commit-bot: I haz the power, 2017-04-28 21:00:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:00:48]

Dry run: This issue passed the CQ dry run.

[wychen, 2017-04-28 21:30:22]

wychen@chromium.org changed reviewers:
+ bajones@chromium.org

[wychen, 2017-04-28 21:30:22]

bajones@chromium.org: Please review changes about VR.

[bajones, 2017-04-28 21:31:30]

On 2017/04/28 21:30:22, wychen wrote:
> mailto:bajones@chromium.org: Please review changes about VR.

vr_shell/ changes LGTM

[wychen, 2017-04-28 21:32:10]

wychen@chromium.org changed reviewers:
+ brettw@chromium.org

[wychen, 2017-04-28 21:32:11]

brettw@, Could you take an overall look?

[brettw, 2017-04-28 21:42:39]

LGTM.

Can you change the CL description to be "Remove non-existing headers from the
build". Saying "from GN" implies to me the GN tool, and there's no ambiguity
about what "the build" means any more.

[wychen, 2017-04-28 21:53:54]

Description was changed from

==========
Remove non-existing headers from GN

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=716359
==========

to

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=716359
==========

[wychen, 2017-04-28 21:55:12]

Description was changed from

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

BUG=716359
==========

to

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

12 missing headers in the build were fixed because they were moved.

BUG=716359
==========

[wychen, 2017-04-28 21:56:26]

On 2017/04/28 21:42:39, brettw (busy this week) wrote:
> LGTM.
> 
> Can you change the CL description to be "Remove non-existing headers from the
> build". Saying "from GN" implies to me the GN tool, and there's no ambiguity
> about what "the build" means any more.

Done. Thanks!

[wychen, 2017-04-28 23:50:06]

Description was changed from

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to fix_gn_headers.py --remove-extra, and
chose which matches to apply interactively.

12 missing headers in the build were fixed because they were moved.

BUG=716359
==========

to

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

12 missing headers in the build were fixed because they were moved.

BUG=716359
==========

[wychen, 2017-04-29 07:29:42]

Description was changed from

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

12 missing headers in the build were fixed because they were moved.

BUG=716359
==========

to

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

8 missing headers in the build were fixed because they were moved.

BUG=716359
==========

[wychen, 2017-04-29 07:30:20]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-04-29 07:30:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org, thakis@chromium.org, bajones@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2849763002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-29 07:30:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 10:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 10:24:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wychen, 2017-04-29 10:35:39]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-04-29 10:35:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 11:10:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493462139451440,
"parent_rev": "b6c07cb297c05e54ce3865a63b9325fdd8222017", "commit_rev":
"31719eefcc4e06a6cb0b41364eb91d0857c2ce2f"}

[commit-bot: I haz the power, 2017-04-29 11:10:23]

Description was changed from

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

8 missing headers in the build were fixed because they were moved.

BUG=716359
==========

to

==========
Remove non-existing headers from the build

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

8 missing headers in the build were fixed because they were moved.

BUG=716359

Review-Url: https://codereview.chromium.org/2849763002
Cr-Commit-Position: refs/heads/master@{#468237}
Committed:
https://chromium.googlesource.com/chromium/src/+/31719eefcc4e06a6cb0b41364eb9...
==========

[commit-bot: I haz the power, 2017-04-29 11:10:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/31719eefcc4e06a6cb0b41364eb9...