Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2849733002: Fix Print Preview failure state and add test (Closed)

Created:
3 years, 7 months ago by rbpotter
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Print Preview failure state and add test Prevent print preview error state from being unrecoverable by resetting the state when the user selects a new printer. Add test to check that the state resets and to check that the response to the INVALID_SETTINGS event is correct. BUG=708834 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2849733002 Cr-Commit-Position: refs/heads/master@{#468379} Committed: https://chromium.googlesource.com/chromium/src/+/a7b31e1ff636ee016885a18953745783c9825616

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix test #

Total comments: 8

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -9 lines) Patch
M chrome/browser/resources/print_preview/print_preview.js View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 2 6 chunks +99 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
rbpotter
3 years, 7 months ago (2017-04-28 01:16:04 UTC) #4
dpapad
https://codereview.chromium.org/2849733002/diff/1/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2849733002/diff/1/chrome/test/data/webui/print_preview.js#newcode157 chrome/test/data/webui/print_preview.js:157: invalidSettings: function() { Nit: |invalidSettings| sounds more like a ...
3 years, 7 months ago (2017-04-28 17:13:31 UTC) #5
rbpotter
https://codereview.chromium.org/2849733002/diff/1/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2849733002/diff/1/chrome/test/data/webui/print_preview.js#newcode157 chrome/test/data/webui/print_preview.js:157: invalidSettings: function() { On 2017/04/28 17:13:30, dpapad wrote: > ...
3 years, 7 months ago (2017-04-29 00:07:11 UTC) #8
dpapad
LGTM with nits. https://codereview.chromium.org/2849733002/diff/40001/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2849733002/diff/40001/chrome/test/data/webui/print_preview.js#newcode182 chrome/test/data/webui/print_preview.js:182: **/ Extra asterisk. */ https://codereview.chromium.org/2849733002/diff/40001/chrome/test/data/webui/print_preview.js#newcode1416 chrome/test/data/webui/print_preview.js:1416: ...
3 years, 7 months ago (2017-04-29 01:20:20 UTC) #12
rbpotter
https://codereview.chromium.org/2849733002/diff/40001/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2849733002/diff/40001/chrome/test/data/webui/print_preview.js#newcode182 chrome/test/data/webui/print_preview.js:182: **/ On 2017/04/29 01:20:20, dpapad wrote: > Extra asterisk. ...
3 years, 7 months ago (2017-04-29 01:32:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849733002/60001
3 years, 7 months ago (2017-05-01 17:54:57 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 19:09:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a7b31e1ff636ee016885a1895374...

Powered by Google App Engine
This is Rietveld 408576698