Add blink unit tests to the linux/mac/windows builders.

Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG=713180, 703894
Review-Url: https://codereview.chromium.org/2849673002
Cr-Commit-Position: refs/heads/master@{#467993}
Committed: https://chromium.googlesource.com/chromium/src/+/aa07565e88d7bf456ece9dc4cf2673b7aad656dc

[danakj, 2017-04-27 21:51:01]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:51:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-27 22:28:17]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-04-27 22:28:21]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 22:30:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-27 22:39:18]

Are there tests that should verify these bots are added appropriately from
analyze? No tests seem to fail for these changes (unlike the api.py ones)

[commit-bot: I haz the power, 2017-04-28 02:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:44:00]

Dry run: This issue passed the CQ dry run.

[mithro, 2017-04-28 04:13:42]

tansell@chromium.org changed reviewers:
+ tansell@chromium.org

[mithro, 2017-04-28 04:13:42]

LGTM! Thanks for doing this (it was on my TODO list).

Sadly I don't know any way of testing these JSON files before landing them.

[mithro, 2017-04-28 04:20:40]

On 2017/04/28 04:13:42, mithro wrote:
> LGTM! Thanks for doing this (it was on my TODO list).
> 
> Sadly I don't know any way of testing these JSON files before landing them.

Could you add BUG=703894 to this CL?

[danakj, 2017-04-28 14:40:33]

Description was changed from

==========
Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG=713180
==========

to

==========
Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG=713180, 703894
==========

[danakj, 2017-04-28 14:40:38]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-04-28 14:40:44]

On 2017/04/28 04:20:40, mithro wrote:
> On 2017/04/28 04:13:42, mithro wrote:
> > LGTM! Thanks for doing this (it was on my TODO list).
> > 
> > Sadly I don't know any way of testing these JSON files before landing them.
> 
> Could you add BUG=703894 to this CL?

Yep done.

[commit-bot: I haz the power, 2017-04-28 14:41:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:46:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493390438968360, "parent_rev":
"d4c124aa6f93deabb5415b6463d8ac6c362e0eab", "commit_rev":
"aa07565e88d7bf456ece9dc4cf2673b7aad656dc"}

[commit-bot: I haz the power, 2017-04-28 14:47:05]

Description was changed from

==========
Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG=713180, 703894
==========

to

==========
Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG=713180, 703894

Review-Url: https://codereview.chromium.org/2849673002
Cr-Commit-Position: refs/heads/master@{#467993}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa07565e88d7bf456ece9dc4cf26...
==========

[commit-bot: I haz the power, 2017-04-28 14:47:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa07565e88d7bf456ece9dc4cf26...

[Dirk Pranke, 2017-05-04 00:51:14]

belated lgtm. Thanks for working on this!