Password manager should autofill a dynamic form added and processed before the page was loaded.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include <stddef.h>
 
 #include <tuple>
 
@@ skipping 719 matching lines @@
   is_generation_popup_possibly_visible_ = false;
 
   GetAutofillDriver()->HidePopup();
 }
 
 bool AutofillAgent::IsUserGesture() const {
   return WebUserGestureIndicator::IsProcessingUserGesture();
 }
 
 void AutofillAgent::DidAssociateFormControlsDynamically() {
-  blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
-
-  // Frame is only processed if it has finished loading, otherwise you can end

[vabr (Chromium), 2017/04/28 19:17:33]

This comment comes from https://codereview.chromium.org/277043002, with some
discussion at
https://codereview.chromium.org/277043002/diff/20001/components/autofill/cont....
Your findings about the "infinitely long loading" confirm that isherman's
concerns were real.

The partially parsed forms were not seen by users, just by some tests which no
longer exist (and logs from which are long gone). I suppose this could happen if
someone inserted a form first into DOM and then modified it, but that seems
uncommon. The bug which is going to be fixed by this is likely more frequent.

[vasilii, 2017/04/28 21:26:23]

The reply of gcasto@ is wrong today. DidAssociateFormControlsDynamically is
called only after DidFinishDocumentLoad(). Moreover, it's called at least 0.3
seconds after DidFinishDocumentLoad(). That is, most likely after
DidFinishLoad().
I'm not sure what "partially parsed form" really means. The code adds a form
with username and inserts the password input 1 sec later? But it still can
happen after the frame loaded.
I think there was a misunderstanding about frame->IsLoading(). It means there is
a video, image etc. still loading. Nothing to do with the DOM structure. $(
document ).ready() corresponds to DidFinishDocumentLoad(). If I don't use
setTimeout then the form is handled in DidFinishDocumentLoad() and the test
passes with the existing code.

-  // up with a partially parsed form.
-  if (frame && !frame->IsLoading()) {
-    ProcessForms();
-    password_autofill_agent_->OnDynamicFormsSeen();
-    if (password_generation_agent_)
-      password_generation_agent_->OnDynamicFormsSeen();
-  }
+  // If the control flow is here than the document was at least loaded. The
+  // whole page doesn't have to be loaded.
+  ProcessForms();
+  password_autofill_agent_->OnDynamicFormsSeen();
+  if (password_generation_agent_)
+    password_generation_agent_->OnDynamicFormsSeen();
 }
 
 void AutofillAgent::DidCompleteFocusChangeInFrame() {
   WebDocument doc = render_frame()->GetWebFrame()->GetDocument();
   WebElement focused_element;
   if (!doc.IsNull())
     focused_element = doc.FocusedElement();
   // PasswordGenerationAgent needs to know about focus changes, even if there is
   // no focused element.
   if (password_generation_agent_ &&
@@ skipping 28 matching lines @@
   return autofill_driver_;
 }
 
 const mojom::PasswordManagerDriverPtr&
 AutofillAgent::GetPasswordManagerDriver() {
   DCHECK(password_autofill_agent_);
   return password_autofill_agent_->GetPasswordManagerDriver();
 }
 
 }  // namespace autofill