Revert "Revert of [Autofill] Enable Autofill for dynamically created forms. (https://codereview.chr…

Revert "Revert of [Autofill] Enable Autofill for dynamically created forms. (https://codereview.chromium.org/242613006/)"

This reverts commit r268113 and additionally prevents frames that are still
loading from being parsed. This behavior was the root cause of the previous
test failures.

BUG=360904
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270279

[Garrett Casto, 2014-05-10 00:11:18]

Hi Ilya,

Since this is a revert with edits, you should only need to review the difference
between the first two patch sets.

[Ilya Sherman, 2014-05-12 19:57:54]

https://codereview.chromium.org/277043002/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/277043002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/autofill_agent.cc:702: // parsed form.
Is this method guaranteed to be called again once the frame has finished
loading?

[Ilya Sherman, 2014-05-12 19:58:33]

Also, is there a small regression test that we could add for the bug that caused
the revert?

[Garrett Casto, 2014-05-12 23:52:50]

Re: Testing - I thought about adding a test but I actually can't trigger this
behavior consistently. I sent an e-mail to Elliot about this to see if there is
a way to force this. If not, then I don't know if it possible.

https://codereview.chromium.org/277043002/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/277043002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/autofill_agent.cc:702: // parsed form.
On 2014/05/12 19:57:54, Ilya Sherman wrote:
> Is this method guaranteed to be called again once the frame has finished
> loading?

I don't think so, but if elements are inserted before the frame has finished
loading we will still see them when DidFinishDocumentLoad() is called.

[Ilya Sherman, 2014-05-13 00:45:32]

Ok, sounds good.  Hopefully Elliot will have some helpful tips on how to test
this; but no need to block this CL on that.  LGTM.

[Garrett Casto, 2014-05-13 22:00:49]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-05-13 22:04:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gcasto@chromium.org/277043002/20001

[commit-bot: I haz the power, 2014-05-14 01:10:06]

Change committed as 270279