Implement ImageData::CropRect()

third_party/WebKit/Source/core/html/ImageData.h

Index: third_party/WebKit/Source/core/html/ImageData.h
diff --git a/third_party/WebKit/Source/core/html/ImageData.h b/third_party/WebKit/Source/core/html/ImageData.h
index c270c6e3dd3c3e37810e0e9b470d86a444676581..87fa3f57227482e22dab20c38a39f10d86160e06 100644
--- a/third_party/WebKit/Source/core/html/ImageData.h
+++ b/third_party/WebKit/Source/core/html/ImageData.h
@@ -39,6 +39,7 @@
 #include "core/imagebitmap/ImageBitmapSource.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/geometry/IntSize.h"
+#include "platform/graphics/CanvasColorParams.h"
 #include "platform/heap/Handle.h"
 #include "platform/wtf/CheckedNumeric.h"
 #include "platform/wtf/Compiler.h"
@@ -108,8 +109,10 @@ class CORE_EXPORT ImageData final : public GarbageCollectedFinalized<ImageData>,
   static ImageData* CreateForTest(const IntSize&,
                                   DOMArrayBufferView*,
                                   const ImageDataColorSettings* = nullptr);
-  static sk_sp<SkColorSpace> GetSkColorSpaceForTest(const CanvasColorSpace&,
-                                                    const CanvasPixelFormat&);
+  static bool CompareImageDataColorSettingsForTest(ImageData*, ImageData*);
+
+  ImageData* MakeCopy();

[fserb, 2017/04/28 14:56:53]

I don't know what use case you have in mind for those two functions, but I'd
reconsider this API.

Drop MakeCopy. Rename MakeSubset to CopyRect (or MakeCopy if you prefer). You
can check if it's a full rect there and do the single memcpy. And drop the
enforce_copy parameter.

[zakerinasab, 2017/04/28 15:40:48]

Good suggestions. Applied.

+  ImageData* MakeSubset(const IntRect&, bool = true);
 
   static CanvasColorSpace GetCanvasColorSpace(const String&);
   static String CanvasColorSpaceName(const CanvasColorSpace&);
@@ -193,9 +196,6 @@ class CORE_EXPORT ImageData final : public GarbageCollectedFinalized<ImageData>,
 
   static DOMFloat32Array* ConvertFloat16ArrayToFloat32Array(const uint16_t*,
                                                             unsigned);
-
-  static sk_sp<SkColorSpace> GetSkColorSpace(const CanvasColorSpace&,
-                                             const CanvasPixelFormat&);
 };
 
 }  // namespace blink