Implement ImageData::CropRect()

third_party/WebKit/Source/core/html/ImageData.h

 /*
  * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 21 matching lines @@
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/core/v8/Uint8ClampedArrayOrUint16ArrayOrFloat32Array.h"
 #include "core/CoreExport.h"
 #include "core/dom/ArrayBufferViewHelpers.h"
 #include "core/dom/DOMTypedArray.h"
 #include "core/html/ImageDataColorSettings.h"
 #include "core/html/canvas/CanvasRenderingContext.h"
 #include "core/imagebitmap/ImageBitmapSource.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/geometry/IntSize.h"
+#include "platform/graphics/CanvasColorParams.h"
 #include "platform/heap/Handle.h"
 #include "platform/wtf/CheckedNumeric.h"
 #include "platform/wtf/Compiler.h"
 #include "platform/wtf/text/WTFString.h"
 #include "third_party/skia/include/core/SkColorSpace.h"
 
 namespace blink {
 
 class ExceptionState;
 class ImageBitmapOptions;
@@ skipping 49 matching lines @@
                                     ExceptionState&);
 
   void getColorSettings(ImageDataColorSettings& result) {
     result = color_settings_;
   }
 
   static ImageData* CreateForTest(const IntSize&);
   static ImageData* CreateForTest(const IntSize&,
                                   DOMArrayBufferView*,
                                   const ImageDataColorSettings* = nullptr);
-  static sk_sp<SkColorSpace> GetSkColorSpaceForTest(const CanvasColorSpace&,
-                                                    const CanvasPixelFormat&);
+  static bool CompareImageDataColorSettingsForTest(ImageData*, ImageData*);
+
+  ImageData* MakeCopy();

[fserb, 2017/04/28 14:56:53]

I don't know what use case you have in mind for those two functions, but I'd
reconsider this API.

Drop MakeCopy. Rename MakeSubset to CopyRect (or MakeCopy if you prefer). You
can check if it's a full rect there and do the single memcpy. And drop the
enforce_copy parameter.

[zakerinasab, 2017/04/28 15:40:48]

Good suggestions. Applied.

+  ImageData* MakeSubset(const IntRect&, bool = true);
 
   static CanvasColorSpace GetCanvasColorSpace(const String&);
   static String CanvasColorSpaceName(const CanvasColorSpace&);
   static ImageDataStorageFormat GetImageDataStorageFormat(const String&);
   static unsigned StorageFormatDataSize(const String&);
   static DOMArrayBufferView*
   ConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat(
       WTF::ArrayBufferContents&,
       CanvasPixelFormat,
       ImageDataStorageFormat);
@@ skipping 63 matching lines @@
   static DOMUint16Array* AllocateAndValidateUint16Array(
       const unsigned&,
       ExceptionState* = nullptr);
 
   static DOMFloat32Array* AllocateAndValidateFloat32Array(
       const unsigned&,
       ExceptionState* = nullptr);
 
   static DOMFloat32Array* ConvertFloat16ArrayToFloat32Array(const uint16_t*,
                                                             unsigned);
-
-  static sk_sp<SkColorSpace> GetSkColorSpace(const CanvasColorSpace&,
-                                             const CanvasPixelFormat&);
 };
 
 }  // namespace blink
 
 #endif  // ImageData_h