Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 2849613002: Use ScopedTaskEnvironment instead of MessageLoopForUI in device tests. (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoopForUI in device tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=reillyg@chromium.org Review-Url: https://codereview.chromium.org/2849613002 Cr-Commit-Position: refs/heads/master@{#467760} Committed: https://chromium.googlesource.com/chromium/src/+/27ff7475715673ebc736e4b198c3e90696d83022

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M device/geolocation/geolocation_provider_impl_unittest.cc View 1 5 chunks +11 lines, -4 lines 0 comments Download
M device/geolocation/wifi_data_provider_chromeos_unittest.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M device/geolocation/wifi_data_provider_common_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M device/geolocation/wifi_data_provider_linux_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M device/u2f/u2f_register_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M device/u2f/u2f_request_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M device/u2f/u2f_sign_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
fdoray
1 year, 10 months ago (2017-04-27 18:31:17 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
1 year, 10 months ago (2017-04-27 18:31:20 UTC) #3
Reilly Grant (use Gerrit)
lgtm
1 year, 10 months ago (2017-04-27 19:01:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849613002/20001
1 year, 10 months ago (2017-04-27 19:08:23 UTC) #12
commit-bot: I haz the power
1 year, 10 months ago (2017-04-27 19:41:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27ff7475715673ebc736e4b198c3...

Powered by Google App Engine
This is Rietveld 408576698