Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2849603004: Introduce PaintPropertyTreeBuilderFragmentContext and use it throughout. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce PaintPropertyTreeBuilderFragmentContext and use it throughout. This is in preparation for actually fragmenting under multicol, in a future patch. BUG=648274 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2849603004 Cr-Commit-Position: refs/heads/master@{#468051} Committed: https://chromium.googlesource.com/chromium/src/+/91dea332b757072ca557cd386fdbf5383c0aa2b7

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Total comments: 1

Patch Set 4 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -194 lines) Patch
M third_party/WebKit/Source/core/paint/FindPaintOffsetAndVisualRectNeedingUpdate.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h View 1 5 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 5 chunks +24 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 1 2 3 5 chunks +66 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 2 3 40 chunks +154 lines, -118 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 2 3 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
chrishtr
https://codereview.chromium.org/2849603004/diff/40001/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right): https://codereview.chromium.org/2849603004/diff/40001/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp#newcode110 third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:110: if (context.tree_builder_context_->fragments[0].current.transform == The next patch will update PaintInvalidator ...
3 years, 7 months ago (2017-04-27 22:25:41 UTC) #5
pdr.
LGTM, can you add (to a readme.md file) a description of what fragments are and ...
3 years, 7 months ago (2017-04-28 16:32:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849603004/60001
3 years, 7 months ago (2017-04-28 17:43:48 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:55:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/91dea332b757072ca557cd386fdb...

Powered by Google App Engine
This is Rietveld 408576698