Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: components/navigation_metrics/navigation_metrics.cc

Issue 2849593002: Use is_same_document term instead of is_in_page for metrics. (Closed)
Patch Set: s/changes/replaces Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_metrics/navigation_metrics.cc
diff --git a/components/navigation_metrics/navigation_metrics.cc b/components/navigation_metrics/navigation_metrics.cc
index be41ff93c90166ccda211d142ece58d6faad6a73..78df32462d84c6b20fdd45000e4f77c56bea629d 100644
--- a/components/navigation_metrics/navigation_metrics.cc
+++ b/components/navigation_metrics/navigation_metrics.cc
@@ -50,7 +50,7 @@ static_assert(arraysize(kSchemeNames) == SCHEME_MAX + 1,
namespace navigation_metrics {
void RecordMainFrameNavigation(const GURL& url,
- bool is_in_page,
+ bool is_same_document,
bool is_off_the_record) {
Scheme scheme = SCHEME_UNKNOWN;
for (int i = 1; i < SCHEME_MAX; ++i) {
@@ -61,7 +61,7 @@ void RecordMainFrameNavigation(const GURL& url,
}
UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameScheme", scheme, SCHEME_MAX);
- if (!is_in_page) {
+ if (!is_same_document) {
UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeDifferentPage", scheme,
SCHEME_MAX);
}
@@ -69,7 +69,7 @@ void RecordMainFrameNavigation(const GURL& url,
if (is_off_the_record) {
UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeOTR", scheme,
SCHEME_MAX);
- if (!is_in_page) {
+ if (!is_same_document) {
UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeDifferentPageOTR",
scheme, SCHEME_MAX);
}

Powered by Google App Engine
This is Rietveld 408576698