Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: components/navigation_metrics/navigation_metrics.cc

Issue 2849593002: Use is_same_document term instead of is_in_page for metrics. (Closed)
Patch Set: s/changes/replaces Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/navigation_metrics/navigation_metrics.h" 5 #include "components/navigation_metrics/navigation_metrics.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "url/gurl.h" 9 #include "url/gurl.h"
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 }; 43 };
44 44
45 static_assert(arraysize(kSchemeNames) == SCHEME_MAX + 1, 45 static_assert(arraysize(kSchemeNames) == SCHEME_MAX + 1,
46 "kSchemeNames should have SCHEME_MAX + 1 elements"); 46 "kSchemeNames should have SCHEME_MAX + 1 elements");
47 47
48 } // namespace 48 } // namespace
49 49
50 namespace navigation_metrics { 50 namespace navigation_metrics {
51 51
52 void RecordMainFrameNavigation(const GURL& url, 52 void RecordMainFrameNavigation(const GURL& url,
53 bool is_in_page, 53 bool is_same_document,
54 bool is_off_the_record) { 54 bool is_off_the_record) {
55 Scheme scheme = SCHEME_UNKNOWN; 55 Scheme scheme = SCHEME_UNKNOWN;
56 for (int i = 1; i < SCHEME_MAX; ++i) { 56 for (int i = 1; i < SCHEME_MAX; ++i) {
57 if (url.SchemeIs(kSchemeNames[i])) { 57 if (url.SchemeIs(kSchemeNames[i])) {
58 scheme = static_cast<Scheme>(i); 58 scheme = static_cast<Scheme>(i);
59 break; 59 break;
60 } 60 }
61 } 61 }
62 62
63 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameScheme", scheme, SCHEME_MAX); 63 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameScheme", scheme, SCHEME_MAX);
64 if (!is_in_page) { 64 if (!is_same_document) {
65 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeDifferentPage", scheme, 65 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeDifferentPage", scheme,
66 SCHEME_MAX); 66 SCHEME_MAX);
67 } 67 }
68 68
69 if (is_off_the_record) { 69 if (is_off_the_record) {
70 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeOTR", scheme, 70 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeOTR", scheme,
71 SCHEME_MAX); 71 SCHEME_MAX);
72 if (!is_in_page) { 72 if (!is_same_document) {
73 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeDifferentPageOTR", 73 UMA_HISTOGRAM_ENUMERATION("Navigation.MainFrameSchemeDifferentPageOTR",
74 scheme, SCHEME_MAX); 74 scheme, SCHEME_MAX);
75 } 75 }
76 } 76 }
77 } 77 }
78 78
79 } // namespace navigation_metrics 79 } // namespace navigation_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698