Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2849583006: [DevTools] Disable contexts in console selector on pause (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Disable contexts in console selector on pause Depending on selected call frame, we only use one specific context per debugger model to evaluate in while on pause. BUG=716306 Review-Url: https://codereview.chromium.org/2849583006 Cr-Commit-Position: refs/heads/master@{#468489} Committed: https://chromium.googlesource.com/chromium/src/+/c0fa1cb6658aafa79d065942a1c0b8a99a57dead

Patch Set 1 #

Patch Set 2 : tests #

Messages

Total messages: 9 (5 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-04-29 00:31:24 UTC) #2
pfeldman
lgtm
3 years, 7 months ago (2017-04-29 01:15:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849583006/20001
3 years, 7 months ago (2017-05-01 22:03:32 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:45:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0fa1cb6658aafa79d065942a1c0...

Powered by Google App Engine
This is Rietveld 408576698