Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2849573002:
Prune ComputeVisibleSelectionInDOMTreeDeprecated from TargetRangesForInputEvent (Closed)
|
Created:
3 years, 7 months ago by Xiaocheng Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune ComputeVisibleSelectionInDOMTreeDeprecated from TargetRangesForInputEvent
This patch prunes a call site of the deprecated function to improve code
health.
BUG=698633
TEST=n/a; no behavioral change
Review-Url: https://codereview.chromium.org/2849573002
Cr-Commit-Position: refs/heads/master@{#467887}
Committed: https://chromium.googlesource.com/chromium/src/+/91d6f941c7c78c434006e85a29239d37e3d56acb
Patch Set 1 #
Messages
Total messages: 19 (15 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
The CQ bit was unchecked by yosin@chromium.org
lgtm L2108 updates layout before calling FrameSelection::computeVisibleSelection() at L2115
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493352572930950, "parent_rev":
"b96dfa5b9c0656cc9a8dc0e67f1ab3b547c45a84", "commit_rev":
"91d6f941c7c78c434006e85a29239d37e3d56acb"}
Message was sent while issue was closed.
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from TargetRangesForInputEvent This patch prunes a call site of the deprecated function to improve code health. BUG=698633 TEST=n/a; no behavioral change ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from TargetRangesForInputEvent This patch prunes a call site of the deprecated function to improve code health. BUG=698633 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2849573002 Cr-Commit-Position: refs/heads/master@{#467887} Committed: https://chromium.googlesource.com/chromium/src/+/91d6f941c7c78c434006e85a2923... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/91d6f941c7c78c434006e85a2923... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
