cc: Reduce the size of PaintOpBuffer.

cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

These changes reduce MonochromePublic.apk from 82,050,524 bytes to
82,042,332 bytes. Before PaintOpBuffer the apk was at 82,034,124 bytes,
so this reduces the binary by 50% of the original growth.

R=enne@chromium.org
BUG=716393, 671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2849563005
Cr-Commit-Position: refs/heads/master@{#469121}
Committed: https://chromium.googlesource.com/chromium/src/+/954ca39066bbc77ca7c653c76a02467644c601d2

[danakj, 2017-04-29 00:06:44]

Description was changed from

==========
cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

R=enne@chromium.org
BUG=716393, 671433
==========

to

==========
cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

R=enne@chromium.org
BUG=716393, 671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-04-29 00:10:08]

Description was changed from

==========
cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

R=enne@chromium.org
BUG=716393, 671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

These changes reduce MonochromePublic.apk from 82,050,524 bytes to
82,042,332 bytes. Before PaintOpBuffer the apk was at 82,034,124 bytes,
so this reduces the binary by 50% of the original growth.

R=enne@chromium.org
BUG=716393, 671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-04-29 00:10:59]

It appears this super segfaults so something is wrong tho xD

[danakj, 2017-05-03 18:11:29]

Fixed PTAL

[danakj, 2017-05-03 18:11:35]

Patchset #1 (id:1) has been deleted

[danakj, 2017-05-03 18:17:10]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 18:18:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-05-03 18:30:32]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[enne (OOO), 2017-05-03 18:30:41]

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
File cc/paint/paint_op_buffer.cc (right):

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
cc/paint/paint_op_buffer.cc:65: static_assert(!T::kHasPaintFlags, "");
Maybe nice to leave a comment in the static assert text?

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
cc/paint/paint_op_buffer.cc:72: void (*raster_fn)(const PaintOp* op,
RasterFunction raster_fn?

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
cc/paint/paint_op_buffer.cc:149: #define M(T) &T::Raster,
Mmm, much nicer.

[commit-bot: I haz the power, 2017-05-03 18:31:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-05-03 19:10:22]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2017-05-03 19:10:46]

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
File cc/paint/paint_op_buffer.cc (right):

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
cc/paint/paint_op_buffer.cc:65: static_assert(!T::kHasPaintFlags, "");
On 2017/05/03 18:30:40, enne wrote:
> Maybe nice to leave a comment in the static assert text?

Done.

https://codereview.chromium.org/2849563005/diff/40001/cc/paint/paint_op_buffe...
cc/paint/paint_op_buffer.cc:72: void (*raster_fn)(const PaintOp* op,
On 2017/05/03 18:30:40, enne wrote:
> RasterFunction raster_fn?

Done.

[commit-bot: I haz the power, 2017-05-03 19:11:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-05-03 20:50:51]

lgtm

[danakj, 2017-05-03 20:51:42]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-05-03 20:51:47]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-05-03 20:52:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 21:08:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493844707037110,
"parent_rev": "0af024d53ed6e1ad7759ed5423ef6f98a9c7f6af", "commit_rev":
"954ca39066bbc77ca7c653c76a02467644c601d2"}

[commit-bot: I haz the power, 2017-05-03 21:08:54]

Description was changed from

==========
cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

These changes reduce MonochromePublic.apk from 82,050,524 bytes to
82,042,332 bytes. Before PaintOpBuffer the apk was at 82,034,124 bytes,
so this reduces the binary by 50% of the original growth.

R=enne@chromium.org
BUG=716393, 671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Reduce the size of PaintOpBuffer.

Step 1:
Moves the non-type-dependent code out of push_internal to a helper
method.

Step 2:
Moves PaintFlags up to a base PaintOpWithFlags class.
Makes FooPaintOp::Raster static.
Moves the non-type-dependant code out of PaintWithAlpha templates (with
a function pointer to FooPaintOp::Raster)
Removes the Rasterizer::Raster template methods, and the RasterFunction
lambdas, replacing them with function pointers to FooPaintOp::Raster
directly.

These changes reduce MonochromePublic.apk from 82,050,524 bytes to
82,042,332 bytes. Before PaintOpBuffer the apk was at 82,034,124 bytes,
so this reduces the binary by 50% of the original growth.

R=enne@chromium.org
BUG=716393, 671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2849563005
Cr-Commit-Position: refs/heads/master@{#469121}
Committed:
https://chromium.googlesource.com/chromium/src/+/954ca39066bbc77ca7c653c76a02...
==========

[commit-bot: I haz the power, 2017-05-03 21:08:55]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/954ca39066bbc77ca7c653c76a02...