Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2849563002: Reland of Break page load metrics test dependency on IPC. (Closed)

Created:
3 years, 7 months ago by Bryan McQuade
Modified:
3 years, 7 months ago
Reviewers:
lpy, zmin
CC:
chromium-reviews, csharrison+watch_chromium.org, jkarlin, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Break page load metrics test dependency on IPC. (patchset #1 id:1 of https://codereview.chromium.org/2847803002/ ) Reason for revert: The flake that caused the previous revert by zmin existed before the original patch landed, so the original patch is not the cause of the flake. This refactor should help us to un-flake the test, so I'm re-landing it. Original issue's description: > Revert of Break page load metrics test dependency on IPC. (patchset #2 id:20001 of https://codereview.chromium.org/2847513002/ ) > > Reason for revert: > PageLoadMetricsBrowserTest.DocumentWriteReloada is flaky > > https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/387 > > Original issue's description: > > Break page load metrics test dependency on IPC. > > > > This change breaks direct dependencies on IPC for page load metrics > > tests, in order to ease the transition to mojo. > > > > Previously, unit tests exercised the IPC dispatch path. This > > achieved slightly increased coverage but coupled unit tests to > > IPC. We now dispatch simulated timing events directly to callbacks, > > bypassing the IPC dispatch. > > > > Additionally, we break the browsertest dependency on IPC and add > > a MetricsWebContentsObserver::TestingObserver, which can observe > > state changes at the observer level, instead of watching for IPC > > messages. This both simplifies the logic and more directly verifies > > expected behavior at the appropriate level. > > > > BUG=715744 > > TBR=csharrison > > > > Review-Url: https://codereview.chromium.org/2847513002 > > Cr-Commit-Position: refs/heads/master@{#467687} > > Committed: https://chromium.googlesource.com/chromium/src/+/9567f9fa3fcfcaa50fc7b6a6adf66106a2eb6be5 > > TBR=lpy@chromium.org,bmcquade@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=715744 > > Review-Url: https://codereview.chromium.org/2847803002 > Cr-Commit-Position: refs/heads/master@{#467691} > Committed: https://chromium.googlesource.com/chromium/src/+/2cb37fe0beb13e6baa8852662362e9204d1ebfa3 TBR=lpy@chromium.org,zmin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715744 Review-Url: https://codereview.chromium.org/2849563002 Cr-Commit-Position: refs/heads/master@{#467695} Committed: https://chromium.googlesource.com/chromium/src/+/44d3a319f57f02f92beb9ceb0ad973d7d4d39c82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -143 lines) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer.h View 5 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 5 chunks +35 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 17 chunks +78 lines, -131 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bryan McQuade
Created Reland of Break page load metrics test dependency on IPC.
3 years, 7 months ago (2017-04-27 15:52:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849563002/1
3 years, 7 months ago (2017-04-27 15:52:44 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:53:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44d3a319f57f02f92beb9ceb0ad9...

Powered by Google App Engine
This is Rietveld 408576698