Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2849533005: Fix and re-enable DeviceSettingsCacheTest. (Closed)

Created:
3 years, 7 months ago by Mattias Nissler (ping if slow)
Modified:
3 years, 7 months ago
Reviewers:
Thiemo Nagel, Nico
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and re-enable DeviceSettingsCacheTest. The device_settings_cache_unittest.cc file was accidentally dropped from the build a long time ago. BUG=chromium:139126, chromium:661774 TEST=DeviceSettingsCacheTest* passes. Review-Url: https://codereview.chromium.org/2849533005 Cr-Commit-Position: refs/heads/master@{#467986} Committed: https://chromium.googlesource.com/chromium/src/+/992dc1adae8123ed7cacdeaa7f321bbbbf7837f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_cache_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Mattias Nissler (ping if slow)
3 years, 7 months ago (2017-04-28 10:47:39 UTC) #2
Nico
lgtm
3 years, 7 months ago (2017-04-28 10:56:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849533005/1
3 years, 7 months ago (2017-04-28 13:49:44 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 14:12:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/992dc1adae8123ed7cacdeaa7f32...

Powered by Google App Engine
This is Rietveld 408576698