build/android/buildbot/bb_device_status_check.py - Issue 284953002: If no battery information, do not try to split.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 284953002: If no battery information, do not try to split. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/buildbot/bb_device_status_check.py

diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py

index 94c741fe13d739da9e949e28dd0125b290dc889e..bca7524f038678c11123cf871066969fcefe4265 100755

--- a/build/android/buildbot/bb_device_status_check.py

+++ b/build/android/buildbot/bb_device_status_check.py

@@ -71,7 +71,7 @@ def DeviceInfo(serial, options):

report = ['Device %s (%s)' % (serial, device_type),

' Build: %s (%s)' %

(device_build, device_adb.old_interface.GetBuildFingerprint()),

- ' %s' % '\n '.join(battery.split('\n')),

+ ' %s' % '\n '.join(battery.split('\n')) if battery else '',

luqui 2014/05/13 22:25:43 This inline if is a bit dense and will be tough fo

luqui 2014/05/13 22:26:38 Better yet, a function "indent", to state your int

navabi 2014/05/13 22:40:30 Done. I didn't think we needed an 'indent' functio

' IMEI slice: %s' % imei_slice,

' Wifi IP: %s' % device_adb.old_interface.GetWifiIP(),

'']

« no previous file with comments | « no previous file | no next file » | no next file with comments »