If no battery information, do not try to split.

build/android/buildbot/bb_device_status_check.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A class to keep track of devices across builds and report state."""
 import logging
 import optparse
 import os
@@ skipping 53 matching lines @@
     return 'Unknown'
 
   ac_power = _GetData('AC powered: (\w+)', battery)
   battery_level = _GetData('level: (\d+)', battery)
   imei_slice = _GetData('Device ID = (\d+)',
                         device_adb.old_interface.GetSubscriberInfo(),
                         lambda x: x[-6:])
   report = ['Device %s (%s)' % (serial, device_type),
             '  Build: %s (%s)' %
               (device_build, device_adb.old_interface.GetBuildFingerprint()),
-            '  %s' % '\n  '.join(battery.split('\n')),
+            '  %s' % '\n  '.join(battery.split('\n')) if battery else '',

[luqui, 2014/05/13 22:25:43]

This inline if is a bit dense and will be tough for anyone who doesn't know
python well.  Factor out into a named variable.

[luqui, 2014/05/13 22:26:38]

Better yet, a function "indent", to state your intent

[navabi, 2014/05/13 22:40:30]

Done. I didn't think we needed an 'indent' function just for that part in
_GetBatteryInfo()

             '  IMEI slice: %s' % imei_slice,
             '  Wifi IP: %s' % device_adb.old_interface.GetWifiIP(),
             '']
 
   errors = []
   if battery_level < 15:
     errors += ['Device critically low in battery. Turning off device.']
   if not options.no_provisioning_check:
     setup_wizard_disabled = (
         device_adb.old_interface.GetSetupWizardStatus() == 'DISABLED')
@@ skipping 261 matching lines @@
     # devices with critically low battery. Remove those devices from testing,
     # allowing build to continue with good devices.
     return 1
 
   if not devices:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())