Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2849513003: Re-add OfflinePageModelQueryTests to build files. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
Dmitry Titov, dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org, chili
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add OfflinePageModelQueryTests to build files. It got lost in https://codereview.chromium.org/2489443002/ (see changes to components/offline_pages/BUILD.gn and components/offline_pages/core/BUILD.gn in that change). BUG=654635, 661774 Review-Url: https://codereview.chromium.org/2849513003 Cr-Commit-Position: refs/heads/master@{#467792} Committed: https://chromium.googlesource.com/chromium/src/+/7a2e1cc92b74ecd7dff00e5cc91e7f21f97dc7cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M components/offline_pages/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/core/offline_page_model_query_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Nico
3 years, 7 months ago (2017-04-27 15:46:35 UTC) #4
dewittj
lgtm, thanks!
3 years, 7 months ago (2017-04-27 21:12:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849513003/1
3 years, 7 months ago (2017-04-27 21:13:11 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 21:25:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a2e1cc92b74ecd7dff00e5cc91e...

Powered by Google App Engine
This is Rietveld 408576698