[EasyUnlock] Fixing the setup connection finder and message format.

[EasyUnlock] Fixing the setup connection finder and message format.

BUG=

Review-Url: https://codereview.chromium.org/2849493002
Cr-Commit-Position: refs/heads/master@{#467937}
Committed: https://chromium.googlesource.com/chromium/src/+/6b932ecddbb02bcc4fa8339e844707a66a1025f8

[sacomoto, 2017-04-27 08:34:31]

The CQ bit was checked by sacomoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 08:34:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 09:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 09:10:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sacomoto, 2017-04-27 09:20:50]

The CQ bit was checked by sacomoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 09:21:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 10:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 10:22:28]

Dry run: This issue passed the CQ dry run.

[sacomoto, 2017-04-27 15:51:07]

Description was changed from

==========
[EasyUnlock] Fixing the setup connection finder and message format.

BUG=
==========

to

==========
[EasyUnlock] Fixing the setup connection finder and message format.

BUG=
==========

[sacomoto, 2017-04-27 15:51:08]

sacomoto@chromium.org changed reviewers:
+ tengs@chromium.org

[sacomoto, 2017-04-27 15:51:21]

The CQ bit was checked by sacomoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 15:51:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 16:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:54:20]

Dry run: This issue passed the CQ dry run.

[sacomoto, 2017-04-28 05:09:37]

I forgot to send for review yesterday... 

PTAL.

[Tim Song, 2017-04-28 05:32:21]

lgtm

https://codereview.chromium.org/2849493002/diff/60001/components/cryptauth/wi...
File components/cryptauth/wire_message.h (right):

https://codereview.chromium.org/2849493002/diff/60001/components/cryptauth/wi...
components/cryptauth/wire_message.h:22: explicit WireMessage(const std::string&
body);
I think it's cleaner to subclass WireMessage (i.e. SetupWireMessage) like you
did for the ConnectionFinder.

https://codereview.chromium.org/2849493002/diff/60001/components/proximity_au...
File components/proximity_auth/bluetooth_low_energy_setup_connection_finder.h
(right):

https://codereview.chromium.org/2849493002/diff/60001/components/proximity_au...
components/proximity_auth/bluetooth_low_energy_setup_connection_finder.h:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
nit: update date

[sacomoto, 2017-04-28 06:59:02]

https://codereview.chromium.org/2849493002/diff/60001/components/cryptauth/wi...
File components/cryptauth/wire_message.h (right):

https://codereview.chromium.org/2849493002/diff/60001/components/cryptauth/wi...
components/cryptauth/wire_message.h:22: explicit WireMessage(const std::string&
body);
On 2017/04/28 05:32:20, Tim Song wrote:
> I think it's cleaner to subclass WireMessage (i.e. SetupWireMessage) like you
> did for the ConnectionFinder.

Discussed offline.

https://codereview.chromium.org/2849493002/diff/60001/components/proximity_au...
File components/proximity_auth/bluetooth_low_energy_setup_connection_finder.h
(right):

https://codereview.chromium.org/2849493002/diff/60001/components/proximity_au...
components/proximity_auth/bluetooth_low_energy_setup_connection_finder.h:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
On 2017/04/28 05:32:20, Tim Song wrote:
> nit: update date

Done.

[sacomoto, 2017-04-28 06:59:13]

The CQ bit was checked by sacomoto@chromium.org

[sacomoto, 2017-04-28 06:59:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2849493002/#ps80001
(title: "date")

[commit-bot: I haz the power, 2017-04-28 06:59:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 09:02:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493362753933410,
"parent_rev": "423b422b6ce147aa3bb4858ab498802751c52c9b", "commit_rev":
"6b932ecddbb02bcc4fa8339e844707a66a1025f8"}

[commit-bot: I haz the power, 2017-04-28 09:02:43]

Description was changed from

==========
[EasyUnlock] Fixing the setup connection finder and message format.

BUG=
==========

to

==========
[EasyUnlock] Fixing the setup connection finder and message format.

BUG=

Review-Url: https://codereview.chromium.org/2849493002
Cr-Commit-Position: refs/heads/master@{#467937}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b932ecddbb02bcc4fa8339e8447...
==========

[commit-bot: I haz the power, 2017-04-28 09:02:44]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6b932ecddbb02bcc4fa8339e8447...