Add documentation on servicification recipes

Add documentation on servicification recipes

This documentation captures insights we've gained during initial
servicifications; hopefully it will be useful for future servicifications.

Review-Url: https://codereview.chromium.org/2849463006
Cr-Commit-Position: refs/heads/master@{#468586}
Committed: https://chromium.googlesource.com/chromium/src/+/77afe7a6999e1592b462aa8ebc0da11ee92ed59d

[blundell, 2017-04-28 11:59:27]

blundell@chromium.org changed reviewers:
+ jam@chromium.org, rockot@chromium.org, sammc@chromium.org, tibell@chromium.org

[blundell, 2017-04-28 11:59:28]

Johan/John/Ken/Sam: Happy to get feedback from anyone who's interested. Thanks!

[Ken Rockot(use gerrit already), 2017-04-28 18:07:34]

LGTM - great starting point!

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md
File docs/servicification.md (right):

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:73: 
PDF compositor[1] demonstrates another option, where a service is defined within
its implementation component.

[1] https://codereview.chromium.org/2832633002

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:76: By default, your service will run on the IO thread.
You can change that by
This is only true specifically of services which are embedded in the browser
process.

[Sam McNally, 2017-05-01 00:51:03]

lgtm

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md
File docs/servicification.md (right):

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:36: contents of your service manifest: the former is the
default, while the latter
Did the policy order get swapped?

[jam, 2017-05-01 15:32:25]

Thanks for doing this! lgtm with just one comment that needs to be addressed

Please link to this from go/servicification when it lands

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md
File docs/servicification.md (right):

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:64: - //content is the default choice. This is where
your service should go if
nit: shouldn't this be based on where the code was living before? i.e.
components/ don't depend on chrome/ but we wouldn't want to move their service
to content.

So I think we should cover 3 cases: code currently in content, chrome, and
components

[blundell, 2017-05-02 09:00:27]

Thanks, all!

Will link to this from go/servicification

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md
File docs/servicification.md (right):

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:36: contents of your service manifest: the former is the
default, while the latter
On 2017/05/01 00:51:03, Sam McNally wrote:
> Did the policy order get swapped?

Oops, yup! Thanks for noticing!

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:64: - //content is the default choice. This is where
your service should go if
On 2017/05/01 15:32:25, jam wrote:
> nit: shouldn't this be based on where the code was living before? i.e.
> components/ don't depend on chrome/ but we wouldn't want to move their service
> to content.
> 
> So I think we should cover 3 cases: code currently in content, chrome, and
> components

Done.

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:73: 
On 2017/04/28 18:07:34, Ken Rockot wrote:
> PDF compositor[1] demonstrates another option, where a service is defined
within
> its implementation component.
> 
> [1] https://codereview.chromium.org/2832633002

Done.

https://codereview.chromium.org/2849463006/diff/20001/docs/servicification.md...
docs/servicification.md:76: By default, your service will run on the IO thread.
You can change that by
On 2017/04/28 18:07:34, Ken Rockot wrote:
> This is only true specifically of services which are embedded in the browser
> process.

Thanks, specified.

[blundell, 2017-05-02 09:00:31]

The CQ bit was checked by blundell@chromium.org

[blundell, 2017-05-02 09:00:31]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jam@chromium.org, sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2849463006/#ps40001
(title: "Response to reviews")

[commit-bot: I haz the power, 2017-05-02 09:00:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 09:08:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493715631204450,
"parent_rev": "7c599d9955031405b5187f9ecdf231cfe5fc7467", "commit_rev":
"77afe7a6999e1592b462aa8ebc0da11ee92ed59d"}

[commit-bot: I haz the power, 2017-05-02 09:09:03]

Description was changed from

==========
Add documentation on servicification recipes

This documentation captures insights we've gained during initial
servicifications; hopefully it will be useful for future servicifications.
==========

to

==========
Add documentation on servicification recipes

This documentation captures insights we've gained during initial
servicifications; hopefully it will be useful for future servicifications.

Review-Url: https://codereview.chromium.org/2849463006
Cr-Commit-Position: refs/heads/master@{#468586}
Committed:
https://chromium.googlesource.com/chromium/src/+/77afe7a6999e1592b462aa8ebc0d...
==========

[commit-bot: I haz the power, 2017-05-02 09:09:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/77afe7a6999e1592b462aa8ebc0d...