Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 2849433002: Adds error handling support for the SwReporter launcher (reland) (Closed)

Created:
3 years, 8 months ago by ftirelo
Modified:
3 years, 7 months ago
Reviewers:
Jialiu Lin
CC:
alito+watch_chromium.org, chromium-reviews, csharp+watch_chromium.org, ftirelo+watch_chromium.org, grt+watch_chromium.org, joenotcharles+watch_chromium.org, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds error handling support for the SwReporter launcher (reland) This CL had been previously landed as: https://chromium.googlesource.com/chromium/src/+/e012fe8a8e4d60ed8eba17fbac5df6d9fc4bcad3 but got reverted because it broke some browser tests: https://chromium.googlesource.com/chromium/src/+/13b26dffd848c02b1ae0f4ed86986b2a474056c1 Review-Url: https://codereview.chromium.org/2849433002 Cr-Commit-Position: refs/heads/master@{#468040} Committed: https://chromium.googlesource.com/chromium/src/+/fdd88ba132b6e7794715aee4d419b02fe7fa37b4

Patch Set 1 #

Patch Set 2 : Debug data #

Patch Set 3 : Bring bool back #

Patch Set 4 : Remove logs #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -30 lines) Patch
M chrome/browser/safe_browsing/srt_chrome_prompt_impl.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/srt_chrome_prompt_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc View 1 2 3 20 chunks +152 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.h View 3 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 9 chunks +34 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (22 generated)
ftirelo
Hi jialiul@, Relanding this CL that got reverted yesterday after it broke the build. It ...
3 years, 7 months ago (2017-04-27 16:55:23 UTC) #6
Jialiu Lin
lgtm
3 years, 7 months ago (2017-04-28 16:57:59 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849433002/80001
3 years, 7 months ago (2017-04-28 17:15:02 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:22:47 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fdd88ba132b6e7794715aee4d419...

Powered by Google App Engine
This is Rietveld 408576698