Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2849373002: Stop storing ScriptValue in MessageEvent (Closed)

Created:
1 year, 1 month ago by bashi
Modified:
11 months, 3 weeks ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop storing ScriptValue in MessageEvent Instaed use wrapper tracing to refer a V8 value from Blink. BUG=501866

Patch Set 1 #

Total comments: 5

Patch Set 2 : rebase #

Patch Set 3 : Fix test #

Patch Set 4 : Fix tests #

Patch Set 5 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -28 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 2 3 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.h View 1 2 6 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 1 2 3 4 12 chunks +51 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 51 (35 generated)
bashi
PTAL
1 year, 1 month ago (2017-05-02 05:37:36 UTC) #6
haraken
https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.cpp File third_party/WebKit/Source/core/events/MessageEvent.cpp (right): https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.cpp#newcode241 third_party/WebKit/Source/core/events/MessageEvent.cpp:241: return ScriptValue(script_state, data_as_v8_value_reference_.NewLocal( Do you know why we don't ...
1 year, 1 month ago (2017-05-02 07:24:41 UTC) #7
bashi
https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.cpp File third_party/WebKit/Source/core/events/MessageEvent.cpp (right): https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.cpp#newcode241 third_party/WebKit/Source/core/events/MessageEvent.cpp:241: return ScriptValue(script_state, data_as_v8_value_reference_.NewLocal( On 2017/05/02 07:24:41, haraken wrote: > ...
1 year, 1 month ago (2017-05-02 07:38:13 UTC) #8
haraken
LGTM https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.h File third_party/WebKit/Source/core/events/MessageEvent.h (right): https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.h#newcode204 third_party/WebKit/Source/core/events/MessageEvent.h:204: TraceWrapperV8Reference<v8::Value> data_as_v8_value_reference_; In a follow-up CL, I'd prefer ...
1 year, 1 month ago (2017-05-02 08:10:14 UTC) #9
bashi
https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.h File third_party/WebKit/Source/core/events/MessageEvent.h (right): https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.h#newcode204 third_party/WebKit/Source/core/events/MessageEvent.h:204: TraceWrapperV8Reference<v8::Value> data_as_v8_value_reference_; On 2017/05/02 08:10:14, haraken wrote: > > ...
1 year, 1 month ago (2017-05-02 08:46:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849373002/1
1 year, 1 month ago (2017-05-02 08:47:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/443385)
1 year, 1 month ago (2017-05-02 09:54:45 UTC) #14
bashi
Please take another look? This CL has changed since you reviewed. https://codereview.chromium.org/2849373002/diff/1/third_party/WebKit/Source/core/events/MessageEvent.cpp File third_party/WebKit/Source/core/events/MessageEvent.cpp (right): ...
1 year, 1 month ago (2017-05-09 08:09:33 UTC) #35
haraken
LGTM
1 year, 1 month ago (2017-05-09 11:01:42 UTC) #36
Yuki
LGTM. FYI, you can determine the world from v8::Value itself. IIUC, you can tell the ...
1 year, 1 month ago (2017-05-09 11:48:03 UTC) #38
bashi
On 2017/05/09 11:48:03, Yuki wrote: > LGTM. > > FYI, you can determine the world ...
1 year, 1 month ago (2017-05-11 01:37:35 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849373002/80001
1 year, 1 month ago (2017-05-11 01:45:42 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451163)
1 year, 1 month ago (2017-05-11 04:25:59 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849373002/80001
1 year, 1 month ago (2017-05-11 04:37:54 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/441671)
1 year, 1 month ago (2017-05-11 08:35:23 UTC) #47
bashi
1 year, 1 month ago (2017-05-12 02:18:08 UTC) #48
We've realized that using TraceWrapperV8Reference in Events requires proper
reference chains from the root set and it seems we don't have those chain yet.
Let me put this CL off until we have a solution for the issue.

Details:
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/1nLw...

Powered by Google App Engine
This is Rietveld 408576698