Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2849363002: Refactored out property specific logic in animation list parsing. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored out property specific logic in animation list parsing. Replaced animation list parsing method ConsumeAnimationPropertyList with a new more general list parsing method ConsumeCommaSeparatedList. This removes the need to pass property information to the list parsing method, instead passing a callback function to be called on each of the items in the list. This is pre work to implementing the parseSingleValue method in the property APIs for the animation properties that expect a list, as the APIs do not take property as an argument. The new ConsumeCommaSeparatedList method can be used in other parts of the code base, which may be done in future patches. This patch - Added ConsumeCommaSeparatedList templated function to CSSPropertyParserHelpers - Made each animation list property in parseSingleValue use the new ConsumeCommaSeparatedList method instead of ConsumeAnimationPropertyList - Deleted ConsumeAnimationPropertyList method BUG=668012 Review-Url: https://codereview.chromium.org/2849363002 Cr-Commit-Position: refs/heads/master@{#469569} Committed: https://chromium.googlesource.com/chromium/src/+/8091ef8119fff447dc756b8dfc6e99b944a479f8

Patch Set 1 #

Patch Set 2 : Fixed crashing layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -24 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +25 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Bugs Nash
3 years, 7 months ago (2017-05-02 03:23:53 UTC) #4
Bugs Nash
Fixed crashing layout tests
3 years, 7 months ago (2017-05-04 06:14:38 UTC) #7
Bugs Nash
3 years, 7 months ago (2017-05-05 00:09:50 UTC) #13
Eric Willigers
lgtm
3 years, 7 months ago (2017-05-05 01:23:34 UTC) #14
Bugs Nash
+suzyh for owners
3 years, 7 months ago (2017-05-05 01:39:37 UTC) #16
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-05 01:45:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849363002/20001
3 years, 7 months ago (2017-05-05 01:46:23 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 01:54:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8091ef8119fff447dc756b8dfc6e...

Powered by Google App Engine
This is Rietveld 408576698