DescriptionRefactored out property specific logic in animation list parsing.
Replaced animation list parsing method ConsumeAnimationPropertyList
with a new more general list parsing method ConsumeCommaSeparatedList.
This removes the need to pass property information to the list parsing
method, instead passing a callback function to be called on each of the
items in the list.
This is pre work to implementing the parseSingleValue method in the
property APIs for the animation properties that expect a list, as the
APIs do not take property as an argument.
The new ConsumeCommaSeparatedList method can be used in other parts of
the code base, which may be done in future patches.
This patch
- Added ConsumeCommaSeparatedList templated function to
CSSPropertyParserHelpers
- Made each animation list property in parseSingleValue use the new
ConsumeCommaSeparatedList method instead of
ConsumeAnimationPropertyList
- Deleted ConsumeAnimationPropertyList method
BUG=668012
Review-Url: https://codereview.chromium.org/2849363002
Cr-Commit-Position: refs/heads/master@{#469569}
Committed: https://chromium.googlesource.com/chromium/src/+/8091ef8119fff447dc756b8dfc6e99b944a479f8
Patch Set 1 #Patch Set 2 : Fixed crashing layout tests #
Messages
Total messages: 22 (14 generated)
|