Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2849343002: [Android] Enable test_results_presentation for gtests (Closed)

Created:
3 years, 7 months ago by BigBossZhiling
Modified:
3 years, 7 months ago
Reviewers:
jbudorick, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enable test_results_presentation for gtests in chromium.linux.json. This cl is for gtests on the android bots that are (still) on chromium.linux. BUG=605572 Review-Url: https://codereview.chromium.org/2849343002 Cr-Commit-Position: refs/heads/master@{#469137} Committed: https://chromium.googlesource.com/chromium/src/+/23935bc344576994ce5eb91be72a3907f7a68f3e

Patch Set 1 #

Patch Set 2 : fix the condition for status equal to null #

Patch Set 3 : sync #

Total comments: 2

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+544 lines, -1 line) Patch
M build/android/pylib/results/presentation/test_results_presentation.py View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 60 chunks +540 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
BigBossZhiling
3 years, 7 months ago (2017-05-01 23:29:14 UTC) #3
jbudorick
lgtm w/ nit https://codereview.chromium.org/2849343002/diff/40001/build/android/pylib/results/presentation/test_results_presentation.py File build/android/pylib/results/presentation/test_results_presentation.py (right): https://codereview.chromium.org/2849343002/diff/40001/build/android/pylib/results/presentation/test_results_presentation.py#newcode156 build/android/pylib/results/presentation/test_results_presentation.py:156: cell(data=result['status'] if result['status'] else 'UNKNOWN', nit: ...
3 years, 7 months ago (2017-05-03 17:11:37 UTC) #4
BigBossZhiling
https://codereview.chromium.org/2849343002/diff/40001/build/android/pylib/results/presentation/test_results_presentation.py File build/android/pylib/results/presentation/test_results_presentation.py (right): https://codereview.chromium.org/2849343002/diff/40001/build/android/pylib/results/presentation/test_results_presentation.py#newcode156 build/android/pylib/results/presentation/test_results_presentation.py:156: cell(data=result['status'] if result['status'] else 'UNKNOWN', On 2017/05/03 17:11:37, jbudorick ...
3 years, 7 months ago (2017-05-03 17:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849343002/60001
3 years, 7 months ago (2017-05-03 17:18:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/426458)
3 years, 7 months ago (2017-05-03 17:28:42 UTC) #10
BigBossZhiling
3 years, 7 months ago (2017-05-03 20:50:11 UTC) #12
BigBossZhiling
Need owner approval. @thakis
3 years, 7 months ago (2017-05-03 20:51:05 UTC) #13
Nico
Sorry, I lack context here. The linked bug links to a design doc that describes ...
3 years, 7 months ago (2017-05-03 20:54:24 UTC) #14
jbudorick
On 2017/05/03 20:54:24, Nico wrote: > Sorry, I lack context here. The linked bug links ...
3 years, 7 months ago (2017-05-03 20:55:55 UTC) #15
Nico
lgtm with fixed cl description then.
3 years, 7 months ago (2017-05-03 20:57:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849343002/60001
3 years, 7 months ago (2017-05-03 21:04:19 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 21:42:19 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/23935bc344576994ce5eb91be72a...

Powered by Google App Engine
This is Rietveld 408576698