Use PaintRecorder instead of PaintRecordBuilder in PlaceholderImage.

Use PaintRecorder instead of PaintRecordBuilder in PlaceholderImage.

Previously, PlaceholderImage was using PaintRecordBuilder incorrectly to
construct an SkImage of its appearance, which triggered a DCHECK in
debug builds.

This CL changes PlaceholderImage to use a PaintRecorder to construct the
SkImage instead.

BUG=717058
Review-Url: https://codereview.chromium.org/2849303002
Cr-Commit-Position: refs/heads/master@{#468542}
Committed: https://chromium.googlesource.com/chromium/src/+/5d206a778cd0c9fbc5b14447e13bf825a20f9152

[sclittle, 2017-05-01 22:30:58]

sclittle@chromium.org changed reviewers:
+ kbr@chromium.org

[sclittle, 2017-05-01 22:30:59]

PTAL

[Ken Russell (switch to Gerrit), 2017-05-01 22:44:58]

Unfortunately I'm not a good reviewer for this change. Trying to find one.

[Ken Russell (switch to Gerrit), 2017-05-01 22:46:28]

kbr@chromium.org changed reviewers:
+ enne@chromium.org, vmpstr@chromium.org

[Ken Russell (switch to Gerrit), 2017-05-01 22:46:28]

I defer to enne's review.

[vmpstr, 2017-05-01 22:54:15]

lgtm

[Ken Russell (switch to Gerrit), 2017-05-01 23:26:08]

lgtm based on vmpstr's review and enne's offline delegation. :)

[enne (OOO), 2017-05-02 01:01:24]

lgtm

[sclittle, 2017-05-02 01:04:12]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2017-05-02 01:04:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 03:07:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493687052427430, "parent_rev":
"88378a6bf7bfc62fb15f79205446dd9cd32962cd", "commit_rev":
"5d206a778cd0c9fbc5b14447e13bf825a20f9152"}

[commit-bot: I haz the power, 2017-05-02 03:08:00]

Description was changed from

==========
Use PaintRecorder instead of PaintRecordBuilder in PlaceholderImage.

Previously, PlaceholderImage was using PaintRecordBuilder incorrectly to
construct an SkImage of its appearance, which triggered a DCHECK in
debug builds.

This CL changes PlaceholderImage to use a PaintRecorder to construct the
SkImage instead.

BUG=717058
==========

to

==========
Use PaintRecorder instead of PaintRecordBuilder in PlaceholderImage.

Previously, PlaceholderImage was using PaintRecordBuilder incorrectly to
construct an SkImage of its appearance, which triggered a DCHECK in
debug builds.

This CL changes PlaceholderImage to use a PaintRecorder to construct the
SkImage instead.

BUG=717058

Review-Url: https://codereview.chromium.org/2849303002
Cr-Commit-Position: refs/heads/master@{#468542}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d206a778cd0c9fbc5b14447e13b...
==========

[commit-bot: I haz the power, 2017-05-02 03:08:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d206a778cd0c9fbc5b14447e13b...