Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2849193002: Revert "Do not abort redirect responses with unadvertised encoding." (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Do not abort redirect responses with unadvertised encoding." This reverts commit 14d9d00fcdd545dc47387443e17c3d9fbb41e5fb. Reverting in hopes of fixing 716594. See it for details. I had to do this manually as codereview complained about file being too big. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true R=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org TBR=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org BUG=716594 Review-Url: https://codereview.chromium.org/2849193002 Cr-Commit-Position: refs/heads/master@{#468353} Committed: https://chromium.googlesource.com/chromium/src/+/da1b049fa7cad45f62965d461c5119a48775ab38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -44 lines) Patch
M net/http/http_network_transaction.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +5 lines, -22 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
3 years, 7 months ago (2017-05-01 18:01:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849193002/1
3 years, 7 months ago (2017-05-01 18:03:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/da1b049fa7cad45f62965d461c5119a48775ab38
3 years, 7 months ago (2017-05-01 18:04:29 UTC) #6
mmenke
This code isn't even used in that test, I believe, so I don't see how ...
3 years, 7 months ago (2017-05-01 18:05:50 UTC) #7
sky
On 2017/05/01 18:05:50, mmenke wrote: > This code isn't even used in that test, I ...
3 years, 7 months ago (2017-05-01 18:20:14 UTC) #8
sky
3 years, 7 months ago (2017-05-01 19:20:57 UTC) #9
Message was sent while issue was closed.
On 2017/05/01 18:20:14, sky wrote:
> On 2017/05/01 18:05:50, mmenke wrote:
> > This code isn't even used in that test, I believe, so I don't see how this
> > revert could fix the issue.
> 
> find-it identified this patch, and looking at the try runs for
> https://codereview.chromium.org/2835403003 you can see a failure of the test.
> Lets move the discussion to the bug.

I reverted this here https://codereview.chromium.org/2852123002/ . So, your
original patch is back on tip-of-tree.

Powered by Google App Engine
This is Rietveld 408576698