Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2849163002: [ash-md] Reduce thread hopping for cheap wallpaper color extraction. (Closed)

Created:
3 years, 7 months ago by bruthig
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[ash-md] Reduce thread hopping for cheap wallpaper color extraction. Recent optimizations to the color_analysis::CalculateProminentColorOfBitmap() has made it more expensive to perform color extraction asynchronously in some cases. This change uses a simple image size heuristic to decide whether to extract colors synchronously or asynchronously. The optimizations made the 0-3 minute scale for the 'Ash.Wallpaper.TimeSpentExtractingColors' histogram overkill so it was replaced with 'Ash.Wallpaper.ColorExtraction.Durations' one which uses a 0-10 second scale. This change also includes a new 'Ash.Wallpaper.ColorExtraction.UserDelay' histogram that includes the thread switching delays incurred by asynchronous calculations. BUG=595010, 712714 TEST=components_unittests --gtest_filter=*WallPaperColorCalculator*yncTest* Review-Url: https://codereview.chromium.org/2824883006 Cr-Commit-Position: refs/heads/master@{#467075} (cherry picked from commit e4135c8d12a6554d16e3bf16a8b79bb6462aa7d8) Review-Url: https://codereview.chromium.org/2849163002 . Cr-Commit-Position: refs/branch-heads/3071@{#324} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b04dec51600619369fb66ae642960d5df26bdbcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -43 lines) Patch
M components/wallpaper/wallpaper_color_calculator.h View 4 chunks +8 lines, -6 lines 0 comments Download
M components/wallpaper/wallpaper_color_calculator.cc View 3 chunks +51 lines, -11 lines 0 comments Download
M components/wallpaper/wallpaper_color_calculator_unittest.cc View 9 chunks +117 lines, -25 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
3 years, 7 months ago (2017-05-01 16:20:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b04dec51600619369fb66ae642960d5df26bdbcd.

Powered by Google App Engine
This is Rietveld 408576698