Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5972)

Unified Diff: chrome/browser/webshare/share_service_impl.h

Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias) (Closed)
Patch Set: Add new line Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webshare/share_service_impl.h
diff --git a/chrome/browser/webshare/share_service_impl.h b/chrome/browser/webshare/share_service_impl.h
index 7fb1609314efcded6284bc0b1d9b5da524fb58b2..db0298c249f793babd816160161d6a3506635c40 100644
--- a/chrome/browser/webshare/share_service_impl.h
+++ b/chrome/browser/webshare/share_service_impl.h
@@ -57,7 +57,7 @@ class ShareServiceImpl : public blink::mojom::ShareService {
// target, or is null if the user cancelled the share. Virtual for testing.
virtual void ShowPickerDialog(
const std::vector<std::pair<base::string16, GURL>>& targets,
- const base::Callback<void(base::Optional<std::string>)>& callback);
+ chrome::WebShareTargetPickerCallback callback);
// Opens a new tab and navigates to |target_url|.
// Virtual for testing purposes.
@@ -88,7 +88,7 @@ class ShareServiceImpl : public blink::mojom::ShareService {
const std::string& text,
const GURL& share_url,
const ShareCallback& callback,
- base::Optional<std::string> result);
+ const base::Optional<std::string>& result);
base::WeakPtrFactory<ShareServiceImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698