Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/browser/webshare/share_service_impl_unittest.cc

Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias) (Closed)
Patch Set: improve comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webshare/share_service_impl_unittest.cc
diff --git a/chrome/browser/webshare/share_service_impl_unittest.cc b/chrome/browser/webshare/share_service_impl_unittest.cc
index 916024c01f39f8d875599d4a2d941177f9167f5c..fd9ecac2b1ae03cf3da26db2549df6a4f7244a00 100644
--- a/chrome/browser/webshare/share_service_impl_unittest.cc
+++ b/chrome/browser/webshare/share_service_impl_unittest.cc
@@ -85,15 +85,14 @@ class ShareServiceTestImpl : public ShareServiceImpl {
return targets_in_picker_;
}
- const base::Callback<void(base::Optional<std::string>)>& picker_callback() {
+ const chrome::WebShareTargetPickerCallback& picker_callback() {
return picker_callback_;
}
private:
void ShowPickerDialog(
const std::vector<std::pair<base::string16, GURL>>& targets,
- const base::Callback<void(base::Optional<std::string>)>& callback)
- override {
+ const chrome::WebShareTargetPickerCallback& callback) override {
// Store the arguments passed to the picker dialog.
targets_in_picker_ = targets;
picker_callback_ = callback;
@@ -126,7 +125,7 @@ class ShareServiceTestImpl : public ShareServiceImpl {
std::vector<std::pair<base::string16, GURL>> targets_in_picker_;
// The callback passed to ShowPickerDialog (which is supposed to be called
// with the user's chosen result, or nullopt if cancelled).
- base::Callback<void(base::Optional<std::string>)> picker_callback_;
+ chrome::WebShareTargetPickerCallback picker_callback_;
};
class ShareServiceImplUnittest : public ChromeRenderViewHostTestHarness {
@@ -343,7 +342,7 @@ TEST_F(ShareServiceImplUnittest, ShareServiceDeletion) {
make_pair(base::UTF8ToUTF16(kTargetName), GURL(kManifestUrlLow))};
EXPECT_EQ(kExpectedTargets, share_service_helper()->GetTargetsInPicker());
- const base::Callback<void(base::Optional<std::string>)> picker_callback =
+ const chrome::WebShareTargetPickerCallback picker_callback =
share_service_helper()->picker_callback();
DeleteShareService();
« chrome/browser/ui/browser_dialogs.h ('K') | « chrome/browser/webshare/share_service_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698