Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9039)

Unified Diff: chrome/browser/webshare/share_service_impl.cc

Issue 2849143002: webshare: Small refactor of WebShare (OnceCallback, const&, and alias) (Closed)
Patch Set: improve comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webshare/share_service_impl.cc
diff --git a/chrome/browser/webshare/share_service_impl.cc b/chrome/browser/webshare/share_service_impl.cc
index 4aca48813cb7b9e3b798b387f6a54bfa1d24fcf9..6c1a15b73e0c104169b860929bf40289be05e191 100644
--- a/chrome/browser/webshare/share_service_impl.cc
+++ b/chrome/browser/webshare/share_service_impl.cc
@@ -104,8 +104,8 @@ bool ShareServiceImpl::ReplacePlaceholders(base::StringPiece url_template,
void ShareServiceImpl::ShowPickerDialog(
const std::vector<std::pair<base::string16, GURL>>& targets,
- const base::Callback<void(base::Optional<std::string>)>& callback) {
-// TODO(mgiuca): Get the browser window as |parent_window|.
+ const chrome::WebShareTargetPickerCallback& callback) {
+ // TODO(mgiuca): Get the browser window as |parent_window|.
chrome::ShowWebShareTargetPickerDialog(nullptr /* parent_window */, targets,
callback);
}
@@ -197,7 +197,7 @@ void ShareServiceImpl::OnPickerClosed(
const std::string& text,
const GURL& share_url,
const ShareCallback& callback,
- base::Optional<std::string> result) {
+ const base::Optional<std::string>& result) {
if (!result.has_value()) {
callback.Run(blink::mojom::ShareError::CANCELED);
return;

Powered by Google App Engine
This is Rietveld 408576698