Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2849133002: Added property id comments to CSSDescriptorIndices entries. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added property id comments to CSSDescriptorIndices entries. Added trailing comments displaying the property api pointed to by all the non-null entries of the CSSDescriptorIndices table in CSSPropertyDescriptor.cpp. This improves the readability of the table. Changes to generated files: https://gist.github.com/BugsNash/44fa796f876d5b4727931a4b63cec386/revisions BUG=668012 Review-Url: https://codereview.chromium.org/2849133002 Cr-Commit-Position: refs/heads/master@{#468490} Committed: https://chromium.googlesource.com/chromium/src/+/b77b74c5af851a15366fc05ca4fabbf8723334af

Patch Set 1 #

Patch Set 2 : fixed trailing whitespace #

Patch Set 3 : replaced unrelated whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_property_apis.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Bugs Nash
3 years, 7 months ago (2017-05-01 05:52:37 UTC) #9
Eric Willigers
lgtm
3 years, 7 months ago (2017-05-01 08:11:37 UTC) #14
Bugs Nash
+suzyh
3 years, 7 months ago (2017-05-01 21:57:36 UTC) #16
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-01 23:22:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849133002/40001
3 years, 7 months ago (2017-05-01 23:38:35 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:46:40 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b77b74c5af851a15366fc05ca4fa...

Powered by Google App Engine
This is Rietveld 408576698