net/http/http_stream_parser.cc - Issue 284913003: Remove DCHECK in HttpStreamParser::ReadResponseHeaders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_parser.cc

Issue 284913003: Remove DCHECK in HttpStreamParser::ReadResponseHeaders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_parser.cc

diff --git a/net/http/http_stream_parser.cc b/net/http/http_stream_parser.cc

index 820c1ba008adec361627178b6e26e4f3c63a27d2..90271f7e9bf41c87094077b95cb1d17c4e0afddc 100644

--- a/net/http/http_stream_parser.cc

+++ b/net/http/http_stream_parser.cc

@@ -344,8 +344,6 @@ int HttpStreamParser::ReadResponseBody(IOBuffer* buf, int buf_len,

if (io_state_ == STATE_DONE)

return OK;

- // Must have response headers with a non-1xx error code.

DCHECK_NE(1, response_->headers->response_code() / 100);

willchan no longer on Chromium 2014/05/15 08:49:02 I'm confused, don't you need to delete this DCHECK

mmenke 2014/05/15 12:20:07 Erm...oops. Added it back for local testing of th

user_read_buf_ = buf;