Remove DCHECK in HttpStreamParser::ReadResponseHeaders.

net/http/http_stream_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_parser.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
@@ skipping 326 matching lines @@
 
 int HttpStreamParser::ReadResponseBody(IOBuffer* buf, int buf_len,
                                        const CompletionCallback& callback) {
   DCHECK(io_state_ == STATE_NONE || io_state_ == STATE_DONE);
   DCHECK(callback_.is_null());
   DCHECK(!callback.is_null());
   DCHECK_LE(buf_len, kMaxBufSize);
 
   if (io_state_ == STATE_DONE)
     return OK;
-
-  // Must have response headers with a non-1xx error code.
   DCHECK_NE(1, response_->headers->response_code() / 100);

[willchan no longer on Chromium, 2014/05/15 08:49:02]

I'm confused, don't you need to delete this DCHECK?

[mmenke, 2014/05/15 12:20:07]

Erm...oops.  Added it back for local testing of the tests, forgot to remove it
again (With the line, the HttpStreamParser test fails in debug mode, the other
one doesn't zero out the pointer, so may not)

Anyhow, now *really* removed.

 
   user_read_buf_ = buf;
   user_read_buf_len_ = buf_len;
   io_state_ = STATE_READ_BODY;
 
   int result = DoLoop(OK);
   if (result == ERR_IO_PENDING)
     callback_ = callback;
 
   return result;
@@ skipping 692 matching lines @@
       request_body->IsInMemory() &&
       request_body->size() > 0) {
     size_t merged_size = request_headers.size() + request_body->size();
     if (merged_size <= kMaxMergedHeaderAndBodySize)
       return true;
   }
   return false;
 }
 
 }  // namespace net