Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 284913002: Revert of Don't show video fullscreen until DidEnterFullscreen() is called (Closed)

Created:
6 years, 7 months ago by qinmin
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, krit, philipj_slow, jbroman, eric.carlson_apple.com, danakj, feature-media-reviews_chromium.org, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Revert of Don't show video fullscreen until DidEnterFullscreen() is called (https://codereview.chromium.org/277823002/) Reason for revert: this breaks webview. DidEnterFullscreen will never be received since webview doesn't support fullscreen api. As a result, video won't enter fullscreen. Original issue's description: > Don't show video fullscreen until DidEnterFullscreen() is called > > For fullscreen video on android, We call showFullscreenOverlay() too early. > We should wait until DidEnterFullscreen() gets called, and then we should let the video element to request the surface view. > Otherwise, if enterFullscreenForElement fails, we will incorrectly showing the fullscreen video in the background. > This CL also removes the hideFullscreenOverlay() call since this is no longer needed. > When exiting fullscreen, video view will automatically be destroyed. > > BUG=367346 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173917 TBR=aelias@chromium.org,trchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=367346 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M Source/web/FullscreenController.cpp View 3 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qinmin
Created Revert of Don't show video fullscreen until DidEnterFullscreen() is called
6 years, 7 months ago (2014-05-13 17:45:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/284913002/1
6 years, 7 months ago (2014-05-13 17:45:54 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 17:46:34 UTC) #3
Message was sent while issue was closed.
Change committed as 173975

Powered by Google App Engine
This is Rietveld 408576698