Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2849123002: Revert of Generate StyleBackgroundData in ComputedStyleBase. (Closed)

Created:
1 year, 1 month ago by shend
Modified:
1 year, 1 month ago
Reviewers:
nainar
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate StyleBackgroundData in ComputedStyleBase. (patchset #2 id:20001 of https://codereview.chromium.org/2841433002/ ) Reason for revert: testing Original issue's description: > Generate StyleBackgroundData in ComputedStyleBase. > > This patch generates the following fields as part of a group: > - background ('storage_only' of type FillLayer) > - background_color ('storage_only' of type Color) > > Since both fields correspond to shorthands, we specify them in > ComputedStyleExtraFields.json5. > > Diff of generated files: > https://gist.github.com/darrnshn/48a62d4ef7efe9f7a8c2b707eb57644f/revisions > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2841433002 > Cr-Commit-Position: refs/heads/master@{#467561} > Committed: https://chromium.googlesource.com/chromium/src/+/9cd2845fb2b733d9d3852839d47f4dc93bdec090 TBR=nainar@chromium.org,rune@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628043 Review-Url: https://codereview.chromium.org/2849123002 Cr-Commit-Position: refs/heads/master@{#468557} Committed: https://chromium.googlesource.com/chromium/src/+/0784842ece8911097e2675e08666b44896ee7ab2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -22 lines) Patch
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/style/StyleBackgroundData.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/style/StyleBackgroundData.cpp View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shend
Created Revert of Generate StyleBackgroundData in ComputedStyleBase.
1 year, 1 month ago (2017-05-01 03:58:03 UTC) #1
shend
Hi Naina, PTAL
1 year, 1 month ago (2017-05-02 02:39:36 UTC) #4
nainar
lgtm
1 year, 1 month ago (2017-05-02 02:43:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849123002/1
1 year, 1 month ago (2017-05-02 02:44:10 UTC) #7
commit-bot: I haz the power
1 year, 1 month ago (2017-05-02 04:31:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0784842ece8911097e2675e08666...

Powered by Google App Engine
This is Rietveld 408576698