Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2849113003: Update a few JumpList comments (Closed)

Created:
3 years, 7 months ago by chengx
Modified:
3 years, 7 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a few JumpList comments This CL removes some obsolete comments. For example, the class RecentlyClosedTabsHandler is gone, so the related comments should be deleted as well. Other comment updates are according to Google C++ style guide. https://google.github.io/styleguide/cppguide.html#Comments BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2849113003 Cr-Commit-Position: refs/heads/master@{#468637} Committed: https://chromium.googlesource.com/chromium/src/+/07cfbaf67fc15e9bab6d586db6b109685fcc4944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/win/jumplist.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/win/jumplist.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
chengx
I am updating other comments in a new CL per request. PTAL, thanks~
3 years, 7 months ago (2017-05-01 22:01:10 UTC) #11
grt (UTC plus 2)
lgtm
3 years, 7 months ago (2017-05-02 10:47:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849113003/40001
3 years, 7 months ago (2017-05-02 14:35:01 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 15:11:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07cfbaf67fc15e9bab6d586db6b1...

Powered by Google App Engine
This is Rietveld 408576698