bluetooth: Fix crash when a notification arrives during a write

bluetooth: Fix crash when a notification arrives during a write

1. Instead of using a boolean to keep track of pending read or writes,
   check if there are non-null callbacks.
2. Check HasPendingRead only when a notification arrives.

BUG=716655
Review-Url: https://codereview.chromium.org/2849113002
Cr-Commit-Position: refs/heads/master@{#468519}
Committed: https://chromium.googlesource.com/chromium/src/+/6ce865fc28199a11109d3b72ad3b5eb52b3ae826

[ortuno, 2017-05-01 04:48:20]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 04:48:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-05-01 05:45:12]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2017-05-01 05:45:12]

scheib: PTAL

[ortuno, 2017-05-01 05:47:56]

Description was changed from

==========
bluetooth: Fix crash when a notification arrives during a write

1. Instead of using a boolean to keep track of pending read or writes,
   check if there are non-null callbacks.
2. Check HasPendingRead only when a notification arrvices.

BUG=716655
==========

to

==========
bluetooth: Fix crash when a notification arrives during a write

1. Instead of using a boolean to keep track of pending read or writes,
   check if there are non-null callbacks.
2. Check HasPendingRead only when a notification arrives.

BUG=716655
==========

[ortuno, 2017-05-01 05:53:40]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 05:53:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 06:02:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 06:02:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2017-05-01 06:44:37]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 06:44:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 08:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 08:25:09]

Dry run: This issue passed the CQ dry run.

[scheib, 2017-05-01 17:41:51]

lgtm

https://codereview.chromium.org/2849113002/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2849113002/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1075: // Tests
that a notification arriving during a pending read doesn't
write

[ortuno, 2017-05-01 23:51:22]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-05-01 23:51:23]

Thanks!

https://codereview.chromium.org/2849113002/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2849113002/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1075: // Tests
that a notification arriving during a pending read doesn't
On 2017/05/01 at 17:41:50, scheib wrote:
> write

Done.

[ortuno, 2017-05-01 23:51:23]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2849113002/#ps100001
(title: "Fix comment typo")

[commit-bot: I haz the power, 2017-05-01 23:51:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 01:06:39]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493682682745750,
"parent_rev": "9146de1595631f543f2388239efba1ed1362704a", "commit_rev":
"6ce865fc28199a11109d3b72ad3b5eb52b3ae826"}

[commit-bot: I haz the power, 2017-05-02 01:06:56]

Description was changed from

==========
bluetooth: Fix crash when a notification arrives during a write

1. Instead of using a boolean to keep track of pending read or writes,
   check if there are non-null callbacks.
2. Check HasPendingRead only when a notification arrives.

BUG=716655
==========

to

==========
bluetooth: Fix crash when a notification arrives during a write

1. Instead of using a boolean to keep track of pending read or writes,
   check if there are non-null callbacks.
2. Check HasPendingRead only when a notification arrives.

BUG=716655

Review-Url: https://codereview.chromium.org/2849113002
Cr-Commit-Position: refs/heads/master@{#468519}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ce865fc28199a11109d3b72ad3b...
==========

[commit-bot: I haz the power, 2017-05-02 01:06:57]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6ce865fc28199a11109d3b72ad3b...